Allow repo name ending in wildcard "*".

Author: yoshiotu

metadata.go

@@ -1091,6 +1091,7 @@ func SaveImageMetadata(metadataSlice []ImageMetadataInfo) {
 }
 
 // ValidRepoName verifies that the name of a repo is in a legal format.
+// A valid name can optionally include a wildcard "*" but only as the last character.
 func ValidRepoName(name string) bool {
 	if len(name) == 0 {
 		return false
@@ -1099,7 +1100,7 @@ func ValidRepoName(name string) bool {
 		blog.Error("Invalid repo name, too long: %s", name)
 		return false
 	}
-	for _, c := range name {
+	for i, c := range name {
 		switch {
 		case c >= 'a' && c <= 'z':
 			continue
@@ -1109,6 +1110,8 @@ func ValidRepoName(name string) bool {
 			continue
 		case c == '/' || c == '_' || c == '-' || c == '.':
 			continue
+		case c == '*' && i == len(name)-1:
+			continue
 		default:
 			blog.Error("Invalid repo name %s", name)
 			return false

metadata_test.go

@@ -28,7 +28,7 @@ func TestGetLocalImageMetadata(t *testing.T) {
 	ReposToProcess[RepoType(metadata.Repo)] = true
 	currentMetadataSlice = GetLocalImageMetadata(MetadataSet)
 
-	for _, localImage := range(currentMetadataSlice) {
+	for _, localImage := range currentMetadataSlice {
 		fmt.Println("localImage: ", localImage)
 		if localImage.Repo == metadata.Repo && localImage.Tag == metadata.Tag {
 			fmt.Println("TestGetLocalImageMetadata succeeded for ", metadata)
@@ -38,3 +38,18 @@ func TestGetLocalImageMetadata(t *testing.T) {
 	t.Fatal("TestGetLocalImageMetadata failed for ", metadata)
 	return
 }
+
+func TestValidRepoName(t *testing.T) {
+	testCases := map[string]bool{
+		"library/ubuntu": true,
+		"abc/def/ghi":    true,
+		"q:x&2":          false,
+		"banyan/*":       true,
+		"foo*bar/xyz":    false,
+	}
+	for repo, expected := range testCases {
+		if ValidRepoName(repo) != expected {
+			t.Fatalf("TestValidRepoName ValidRepoName(%s) did not return %v", repo, expected)
+		}
+	}
+}