Merge pull request #369 from bavix/develop

[7.x. Stage 1] add new exception (UnconfirmedInvalid)

Author: rez1dent3

src/Exceptions/AmountInvalid.php

@@ -1,9 +1,11 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Bavix\Wallet\Exceptions;
 
 use InvalidArgumentException;
 
-class AmountInvalid extends InvalidArgumentException
+final class AmountInvalid extends InvalidArgumentException
 {
 }

src/Exceptions/BalanceIsEmpty.php

@@ -1,7 +1,9 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Bavix\Wallet\Exceptions;
 
-class BalanceIsEmpty extends InsufficientFunds
+final class BalanceIsEmpty extends InsufficientFunds
 {
 }

src/Exceptions/ConfirmedInvalid.php

@@ -4,6 +4,6 @@
 
 use InvalidArgumentException;
 
-class ConfirmedInvalid extends InvalidArgumentException
+final class ConfirmedInvalid extends InvalidArgumentException
 {
 }

src/Exceptions/InsufficientFunds.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Bavix\Wallet\Exceptions;
 
 use LogicException;

src/Exceptions/ProductEnded.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Bavix\Wallet\Exceptions;
 
 use LogicException;

src/Exceptions/UnconfirmedInvalid.php

@@ -0,0 +1,11 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Bavix\Wallet\Exceptions;
+
+use InvalidArgumentException;
+
+final class UnconfirmedInvalid extends InvalidArgumentException
+{
+}

src/Exceptions/WalletOwnerInvalid.php

@@ -1,9 +1,11 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Bavix\Wallet\Exceptions;
 
 use InvalidArgumentException;
 
-class WalletOwnerInvalid extends InvalidArgumentException
+final class WalletOwnerInvalid extends InvalidArgumentException
 {
 }

src/Traits/CanConfirm.php

@@ -5,6 +5,7 @@
 use Bavix\Wallet\Exceptions\BalanceIsEmpty;
 use Bavix\Wallet\Exceptions\ConfirmedInvalid;
 use Bavix\Wallet\Exceptions\InsufficientFunds;
+use Bavix\Wallet\Exceptions\UnconfirmedInvalid;
 use Bavix\Wallet\Exceptions\WalletOwnerInvalid;
 use Bavix\Wallet\Interfaces\Confirmable;
 use Bavix\Wallet\Interfaces\Mathable;
@@ -59,7 +60,7 @@ public function safeConfirm(Transaction $transaction): bool
     /**
      * Removal of confirmation (forced), use at your own peril and risk.
      *
-     * @throws ConfirmedInvalid
+     * @throws UnconfirmedInvalid
      */
     public function resetConfirm(Transaction $transaction): bool
     {
@@ -74,7 +75,7 @@ public function resetConfirm(Transaction $transaction): bool
                 }
 
                 if (!$transaction->confirmed) {
-                    throw new ConfirmedInvalid(trans('wallet::errors.unconfirmed_invalid'));
+                    throw new UnconfirmedInvalid(trans('wallet::errors.unconfirmed_invalid'));
                 }
 
                 $mathService = app(Mathable::class);

tests/ConfirmTest.php

@@ -3,6 +3,7 @@
 namespace Bavix\Wallet\Test;
 
 use Bavix\Wallet\Exceptions\ConfirmedInvalid;
+use Bavix\Wallet\Exceptions\UnconfirmedInvalid;
 use Bavix\Wallet\Exceptions\WalletOwnerInvalid;
 use Bavix\Wallet\Test\Factories\BuyerFactory;
 use Bavix\Wallet\Test\Factories\UserConfirmFactory;
@@ -136,7 +137,7 @@ public function testConfirmedInvalid(): void
 
     public function testUnconfirmedInvalid(): void
     {
-        $this->expectException(ConfirmedInvalid::class);
+        $this->expectException(UnconfirmedInvalid::class);
         $this->expectExceptionMessageStrict(trans('wallet::errors.unconfirmed_invalid'));
 
         /** @var Buyer $buyer */