Use find-cache-dir to determine cache directory. #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses `find-cache-dir` for consistent cache locating with AVA, etc. It takes the extra step of ensuring a `package.json` file exists (and hunting up the directory tree for it), otherwise it returns null. If it can't find a suitable cache directory, caching is disabled. I also dropped the `cacheDirectory()` method in favor of just setting a property.
|
Nice! |
|
@jamestalmage this seems like a smart change, land when you're ready -- perhaps we can get a new nyc out the door today once I test @isaacs's branch a bit more on Windows. |
bcoe
added a commit
that referenced
this pull request
Jan 2, 2016
Use find-cache-dir to determine cache directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
find-cache-dirfor consistent cache locating with other modules (currently that list only includes AVA, but one can hope). It takes the extra step of ensuring apackage.jsonfile exists (and hunting up the directory tree for it), otherwise it returns null. If it can't find a suitable cache directory, caching is disabled.I also dropped the
cacheDirectory()method in favor of just setting a property.