Preserve function skip annotations #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If present, `skip` should only be `true`. Copy it to the mapped location only if that's the case. This avoids setting `skip` to `undefined` while mapping the report. Note that JSON.stringify() is used when writing the report to disk, so the undefined values wouldn't have ended up in the reports before.
Istanbul may mark functions as being skipped. Make sure these annotations are preserved when source maps are applied.
Closed
|
Works perfectly! Report screenshot in my actual project: before:
after:
Thanks! |
|
@kentcdodds great! |
|
@novemberborn wonderful work, |
and I'll cut a release soon.
novemberborn
added a commit
that referenced
this pull request
Feb 2, 2016
Preserve function skip annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Istanbul may mark functions as being skipped. Make sure these annotations are preserved when source maps are applied. Fixes #67.