add shortcut for istanbul's check-coverage command #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will do; Working on a node service scaffold this weekend; I'll add |
|
👍 |
bcoe
added a commit
that referenced
this pull request
Jun 24, 2015
add shortcut for istanbul's check-coverage command
|
Verified locally; works for me :) thanks |
| // run a report. | ||
| process.env.NYC_CWD = process.cwd() | ||
|
|
||
| ;(new NYC({ | ||
| reporter: argv.reporter | ||
| })).report() | ||
| } else if (~argv._.indexOf('check-coverage')) { | ||
| foreground( | ||
| path.resolve(__dirname, '../node_modules/.bin/istanbul'), |
There was a problem hiding this comment.
This will break if the istanbul dependency was fulfilled by a version installed in a parent node_modules. Or if your dependency tree has been flattened by npm@3, if I'm not mistaken...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added shortcut for istanbul's check-coverage command, see #29
@Raynos, would you mind giving this branch a spin, and letting me know if this was what you're looking for?