Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rmg pointed out in this pull request #30 that istanbul was being invoked in a manner that would work poorly if istanbul got hoisted up into a higher folder.
I've switched to using an approach which @othiym23 and @iarna suggested today:
cwd
, so that I can invoke the npm run script from the context of nyc.@jasisk I also added the
statements
option in this pull we didn't actually collide on thes
key, becauses
was used on the outeryargs
chain, not the inneryargs
chain.Let me know what ya'll think.