added --all flag for indicating that all files should have coverage applied

[bcoe]

I opted for the flag --all rather than --complete and added a some tests.

@ronkorving mind trying out this branch and letting me know if it does the trick for you?

[ronkorving]

The rename and implementation changes are fine with me 👍

[bcoe]

@ronkorving awesome, did you try it out on a few of your modules? does it do the trick -- if so I'll get this merged tonight.

[ronkorving]

I'm having issues, will report back once I find out what it is.

[ronkorving]

By the way, running nyc with an unknown option (I first used --complete) gives a very cryptic error:

internal/child_process.js:298
    throw errnoException(err, 'spawn');
    ^

Error: spawn EACCES
    at exports._errnoException (util.js:837:11)
etc...

[ronkorving]

We are now reading full file contents of files that should be excluded. Potentially quite a painful performance hit.

[ronkorving]

So for some reason, I'm getting this error on this file (a few thousand files up to this point did not give an error):

...
READING node_modules/express/node_modules/proxy-addr/node_modules/ipaddr.js
fs.js:603
  var r = binding.read(fd, buffer, offset, length, position);
                  ^

Error: EISDIR: illegal operation on a directory, read
    at Error (native)
    at Object.fs.readSync (fs.js:603:19)
    at Object.fs.readFileSync (fs.js:438:24)
    at NYC.addFile (CENSORED/node_modules/nyc/index.js:66:29)
etc

While running:

./node_modules/.bin/nyc --all ./node_modules/.bin/tape test/*.js

And while having added a console.log statement to see which file was blowing up:

 65   console.log('READING', filename);
 66   var content = stripBom(fs.readFileSync(filename, 'utf8'))

[ronkorving]

I understand the problem now. Before, node_modules was being ignored and we didn't read anything. ipaddr.js which you see there is the name of an NPM module, and is therefore a directory, not a file. We're now doing readFileSync on everything, even when in an exclude path. My PR didn't do that and it used findFile which doesn't return folders, unlike glob, which is why it didn't blow up before.

I would recommend some refactoring here to:

• stop reading files we exclude.
• run fs.statSync on what glob returns to make sure it's actually a file we can read.

[bcoe]

@ronkorving give that update a shot.

With regards to the error you're seeing passing --complete, unfortunately there's no quick fix that I can think of. Since there's no way to know that --complete is a boolean argument (since it's an unknown flag), it's hard for the argument parser to know not to consume the next token.

[ronkorving]

Looks good, let me try again 👍

[ronkorving]

\o/ victory!
I'm happy if you are, merge away :)

[ronkorving]

Good to go? :) Sorry for the impatience, but I can't wait to integrate this into my projects.

[ronkorving]

Awesome :) If you could follow that up with an NPM release, you'll have made my day ;)

[bcoe]

@ronkorving go ahead and try:

npm install nyc@next

I'm going to test out the changes on a few of my libraries, and if everything is looking good will move the the tag next to latest.

[ronkorving]

I have no idea how to update my package.json file to use @next (this concept of next/latest is new to me). But with a manual install as you showed, it all works fine for me 👍