Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrolab vs classic notebook - truncation of scatter plots #2993

Closed
davidwagner opened this issue Nov 12, 2021 · 3 comments
Closed

Retrolab vs classic notebook - truncation of scatter plots #2993

davidwagner opened this issue Nov 12, 2021 · 3 comments

Comments

@davidwagner
Copy link

Scatter plots seem to be truncated differently in classic notebook vs Retrolab. For example, compare the output of cell 15 in lec10 demos:

classic notebook: http://data8.datahub.berkeley.edu/hub/user-redirect/git-sync?repo=https://github.com/data-8/materials-fa21&subPath=lec/lec10.ipynb

lec10cell15classic

Retrolab: https://data8.datahub.berkeley.edu/hub/user-redirect/git-pull?repo=https%3A%2F%2Fgithub.com%2Fdata-8%2Fmaterials-fa21&branch=master&urlpath=retro%2Ftree%2Fmaterials-fa21%2Flec%2Flec10.ipynb

lec10cell15retro

Not the biggest deal in the world, but Retrolab looks worse to my eyes. Any ideas or suggestions on how to control the truncation/size of the scrollable frame that scatter plots are put into, in Retrolab?

@jtpio
Copy link
Contributor

jtpio commented Nov 16, 2021

Thanks @davidwagner for reporting 👍

Agree, and we should be able to tweak the CSS to make it look nicer.

For example by applying a padding-top: 6px (to match the box shadow blur radius):

image

@yuvipanda
Copy link
Contributor

yuvipanda commented Jan 3, 2022

It looks like this in retrolab now

image

Thanks to @jtpio for this!

@balajialg
Copy link
Contributor

balajialg commented Jan 3, 2022

@jtpio Thanks a lot for fixing all the reported issues in the new retro lab release. Appreciate it!

@yuvipanda Thanks for testing all the changes and deploying them in Datahub. Look forward to retro lab being used in Data 8 during this semester.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants