biome incorrectly collapses whitespace on closing paren

[maxpetretta]

for the last week or so, the biome extension in zed has been incorrectly collapsing whitespace, specifically when typing a closing paren. the issue seems to only happen when there is an existing return statement within the function (see video). removing the extension from zed fixes the issue.

note: i am not saving in the video after typing the closing paren, so formatting should not be taking place

versions:

zed v0.178.5
biome extension v0.1.4

to reproduce:

bun init biome-zed-test
cd ./biome-zed-test
bunx biome init # default config used
zed . # try writing a function

CleanShot.2025-03-24.at.21.32.00.mp4

[ematipico]

note: i am not saving in the video after typing the closing paren, so formatting should not be taking place

If it worked before, then I'm not sure it's a Biome bug. Did you update something related to biome?

note: i am not saving in the video after typing the closing paren, so formatting should not be taking place

Maybe you have some settings that allow that? Or some other extension is getting in the way?

[github-actions]

Hello @maxpetretta, please provide a minimal reproduction. You can use one of the following options:

• Provide a link to our playground, if it's applicable.
• Provide a link to GitHub repository. To easily create a reproduction, you can use our interactive CLI via npm create @biomejs/biome-reproduction

Issues marked with S-Needs repro will be closed if they have no activity within 3 days.

[maxpetretta]

@ematipico i haven't updated biome to my knowledge, v1.9.4. i have zed's autosave setting set to "off" for the demo.

i've also tried the extension's new update released this morning, same behavior.

i only have theme/language extensions installed (besides biome). i'll see if i can try a clean zed install tonight

[wcastand]

i get it too, happens on ) or ] i'm on preview of zed

[tom-james-watson]

I've also been getting this for the past couple of weeks and I can fix it by uninstalling this extension, though obviously that's not really an option if our codebase uses biome formatting.

I don't think this should have been closed.

[tom-james-watson]

I see this with versions 0.1.5, 0.1.4, and 0.1.3. I didn't test any earlier. I think mostly likely there has been some change in Zed which has broken this extension.

[ematipico]

No one has provided a reproduction. I'd be happy to open it if a reproduction is provided

[maxpetretta]

My apologies, that was on me.

@ematipico here is a reproduction: https://github.com/maxpetretta/biome-zed-whitespace-closing-paren

[ematipico]

@maxpetretta can you also please add the zed settings? Usually they are inside .zed/settings.json

[maxpetretta]

i have added my personal zed settings to the repo