🐛 Doesn't seem to work with 2.0.0 yet

[radiosilence]

Zed version

Zed 0.180.4 – /Applications/Zed.app

Extension version

0.1.5

Biome version

2.0.0-beta

Operating system

• Windows
• macOS
• Linux

Description

https://biomejs.dev/blog/biome-v2-0-beta/

Steps to reproduce

1. Install biome 2.0.0 in project
2. Things don't seem to work

Expected behavior

1. It works as normal

Does this issue occur when using the CLI directly?

No

Link to a minimal reproduction

No response

[github-actions]

Hello @radiosilence, please provide a minimal reproduction. You can use one of the following options:

• Provide a link to our playground, if it's applicable.
• Provide a link to GitHub repository. To easily create a reproduction, you can use our interactive CLI via npm create @biomejs/biome-reproduction

Issues marked with S-Needs repro will be closed if they have no activity within 3 days.

[radiosilence]

Hello @radiosilence, please provide a minimal reproduction. You can use one of the following options:

• Provide a link to our playground, if it's applicable.
• Provide a link to GitHub repository. To easily create a reproduction, you can use our interactive CLI via npm create @biomejs/biome-reproduction

Issues marked with S-Needs repro will be closed if they have no activity within 3 days.

@dyc3 I can't do this because it's a problem with the zed extension in zed which doesn't exist in the playground

[ematipico]

@radiosilence

The automated message gives you two options. It's obvious that for your use case, you want to provide a repository, with zed settings included.

[radiosilence]

Ah ok I'll try to replicate when home. Is the expected behaviour that the current extension version will work with biome 2 beta?

[ematipico]

Yeah it should work!

[radiosilence]

@ematipico Ok here we go! https://github.com/radiosilence/zed-biome-2

[Stanislav-Lapata]

I get this error

Language server error: biome

server shut down
-- stderr--
Error: `--config-path` is not expected in this context

some debug info

$ node_modules/@biomejs/biome/bin/biome --version
# Version: 2.0.0-beta.1

$ node_modules/@biomejs/biome/bin/biome lsp-proxy --config-path biome.json
# Error: --config-path is not expected in this context

edited

I think it has connection with caching
When I checked folder ~/Library/Application\ Support/Zed/extensions/work/biome/node_modules/@biomejs/cli-darwin-x64, I found package.json that contained

{
  "name": "@biomejs/cli-darwin-x64",
  "version": "1.9.4",
  "license": "MIT OR Apache-2.0",
  "repository": {
    "type": "git",
    "url": "git+https://github.com/biomejs/biome.git",
    "directory": "packages/@biomejs/biome"
  },
  "engines": {
    "node": ">=14.21.3"
  },
  "homepage": "https://biomejs.dev",
  "os": [
    "darwin"
  ],
  "cpu": [
    "x64"
  ]
}

and biome

~/Library/Application\ Support/Zed/extensions/work/biome/node_modules/@biomejs/cli-darwin-x64/biome --version
# Version: 1.9.4

I removed them and and open zed with zed . command after that it works

[ematipico]

--config-path was removed in v2 in favour of workspace configurations, which means that you have to specify the configuration path in the Biome settings of your settings.json

{
	"lsp": {
		"biome": {
			"configuration_path": ""
		}
	}
}

[radiosilence]

My zed settings.json now has

  "lsp": {
    "biome": {
      "settings": {
        "require_config_file": true,
        "configuration_path": "./biome.json"
      }
    }
  }

And on my demo project, on opening getting:

Language server error: biome

server shut down
-- stderr--
Error: `--config-path` is not expected in this context

I've tried running:

rm -rf ~/Library/Application\ Support/Zed/extensions/work/biome/

Still get the error

[ematipico]

Found the issue, however, debugging in Zed is awful. I'm keen to make a breaking change, and make 0.2.0 compatible only with the beta onward.

[ematipico]

The problem is caused by

biome-zed/src/biome.rs

Lines 127 to 130 in 90eff9b

	zed::npm_package_installed_version(PACKAGE_NAME)
	.ok()
	.flatten()
	.is_some_and(|version| version.starts_with("1."))

The value returned is always true, even though the reproduction doesn't use v1, and as result --config-path is always appended. I can't the debug the value returned by zed::npm_package_installed_version