Description

noConstantCondition currently checks a limited set of expressions to determine whether they evaluate to a constant truthiness or falsiness. We can improve this by changing the rule to make use of the Typed service so that it can pull in type information from identifiers too.

I just noticed the rule has quite an extensive set of tests already, so getting our type infrastructure to handle all of those correctly is probably quite a bit of work already. Feel free to divide the work into chunks if possible, or ask for help if there are any questions!