You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merge #143: cleanup: initialize vars in the EventLoop constructor in the correct order
f52d08c cleanup: initialize vars in the EventLoop constructor in the correct order (Cory Fields)
Pull request description:
This legitimate warning pops up when built with clang 20 and Core's flags:
`warning: field 'm_context' will be initialized after field 'm_task_set' [-Wreorder-ctor]`
It looks like there are no dependency issues here and the reordering is safe, but please let me know if I'm wrong.
ACKs for top commit:
ryanofsky:
Code review ACK f52d08c. Looks good, thanks for the fix!
hebasto:
ACK f52d08c, tested on Ubuntu 24.04:
Tree-SHA512: 13ae8faf8565083353dfa53a8d36d19296c9fd41fa6621ac78fd3bde8b222848e4c536f9949ecf6a19b9a4f2aee3f51fb0379f5ce61d6e9636af050caba1122a
0 commit comments