Skip to content

Commit 792933c

Browse files
committed
Auto merge of rust-lang#95317 - Jules-Bertholet:round_ties_to_even, r=pnkfelix,m-ou-se,scottmcm
Add `round_ties_even` to `f32` and `f64` Tracking issue: rust-lang#96710 Redux of rust-lang#82273. See also rust-lang#55107 Adds a new method, `round_ties_even`, to `f32` and `f64`, that rounds the float to the nearest integer , rounding halfway cases to the number with an even least significant bit. Uses the `roundeven` LLVM intrinsic to do this. Of the five IEEE 754 rounding modes, this is the only one that doesn't already have a round-to-integer function exposed by Rust (others are `round`, `floor`, `ceil`, and `trunc`). Ties-to-even is also the rounding mode used for int-to-float and float-to-float `as` casts, as well as float arithmentic operations. So not having an explicit rounding method for it seems like an oversight. Bikeshed: this PR currently uses `round_ties_even` for the name of the method. But maybe `round_ties_to_even` is better, or `round_even`, or `round_to_even`?
2 parents 1b57cb6 + 20d6292 commit 792933c

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/intrinsics/mod.rs

+4
Original file line numberDiff line numberDiff line change
@@ -281,8 +281,12 @@ fn codegen_float_intrinsic_call<'tcx>(
281281
sym::ceilf64 => ("ceil", 1, fx.tcx.types.f64),
282282
sym::truncf32 => ("truncf", 1, fx.tcx.types.f32),
283283
sym::truncf64 => ("trunc", 1, fx.tcx.types.f64),
284+
sym::rintf32 => ("rintf", 1, fx.tcx.types.f32),
285+
sym::rintf64 => ("rint", 1, fx.tcx.types.f64),
284286
sym::roundf32 => ("roundf", 1, fx.tcx.types.f32),
285287
sym::roundf64 => ("round", 1, fx.tcx.types.f64),
288+
sym::roundevenf32 => ("roundevenf", 1, fx.tcx.types.f32),
289+
sym::roundevenf64 => ("roundeven", 1, fx.tcx.types.f64),
286290
sym::sinf32 => ("sinf", 1, fx.tcx.types.f32),
287291
sym::sinf64 => ("sin", 1, fx.tcx.types.f64),
288292
sym::cosf32 => ("cosf", 1, fx.tcx.types.f32),

0 commit comments

Comments
 (0)