You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Do you want to request a feature or report a bug?
FEATURE
What is the current behavior?
Any exception caught by ResilientExecuteRenderer logs the exception with Log.Error(...)
If the current behavior is a bug, please provide the steps to reproduce.
What is the expected/desired behavior?
Move the Log.Error statement into its own new virtual method (LogException?) to allow it to be easily overridden.
publicoverridevoidProcess(RenderRenderingArgsargs){try{base.Process(args);}catch(Exceptionexception){args.Cacheable=false;LogException(exception);Exceptionex=ProcessException(exception);RenderingErrorModelmodel=CreateRenderingErrorModel(args,ex);if(!DispatchPossibleModelException(model,args.PageContext.RequestContext,args.Writer)){DispatchException(model,args.PageContext.RequestContext,args.Writer);}}}protectedvirtualvoidLogException(Exceptionexception){Log.Error("Error occurred rendering a view.",exception,GetType());}
I can submit a PR if this seems reasonable.
Please mention your Sitecore version and Synthesis version.
Sitecore 9.3
Synthesis 9.1.0.2
The text was updated successfully, but these errors were encountered:
sitecorepm
changed the title
Allow more flexibility with ResilientExecuteRenderer to allow customized exception behavior
Add flexibility with ResilientExecuteRenderer to allow customized exception behavior
Apr 1, 2022
Do you want to request a feature or report a bug?
FEATURE
What is the current behavior?
Any exception caught by ResilientExecuteRenderer logs the exception with Log.Error(...)
If the current behavior is a bug, please provide the steps to reproduce.
What is the expected/desired behavior?
Move the Log.Error statement into its own new virtual method (LogException?) to allow it to be easily overridden.
I can submit a PR if this seems reasonable.
Please mention your Sitecore version and Synthesis version.
Sitecore 9.3
Synthesis 9.1.0.2
The text was updated successfully, but these errors were encountered: