Skip to content
This repository was archived by the owner on Jan 8, 2019. It is now read-only.

Commit b357859

Browse files
authored
Merge pull request #1277 from vt0r/disable_bucketcache_masters
Disable bucket cache on HBase masters
2 parents fe63ba7 + fbe2a73 commit b357859

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

cookbooks/bcpc-hadoop/recipes/hbase_config.rb

+6-1
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,12 @@
134134
# If HBASE bucket cache is enabled the properties from this section will be included in hbase-site.xml
135135
#
136136
bucketcache_size = (node['bcpc']['hadoop']['hbase_rs']['mx_dir_mem']['size'] - node['bcpc']['hadoop']['hbase_rs']['hdfs_dir_mem']['size']).floor
137-
if node['bcpc']['hadoop']['hbase']['bucketcache']['enabled'] == true
137+
bucketcache_enabled = node['bcpc']['hadoop']['hbase']['bucketcache']['enabled']
138+
is_region_server = node['bcpc']['hadoop']['rs_hosts'].any? do |rs|
139+
rs.values[0] == node['fqdn']
140+
end
141+
142+
if bucketcache_enabled && is_region_server
138143
generated_values['hbase.regionserver.global.memstore.upperLimit'] = node['bcpc']['hadoop']['hbase_rs']['memstore']['upperlimit'].to_s
139144
generated_values['hfile.block.cache.size'] = node['bcpc']['hadoop']['hbase']['blockcache']['size'].to_s
140145
generated_values['hbase.bucketcache.size'] = bucketcache_size

cookbooks/bcpc-hadoop/recipes/hbase_env.rb

-4
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,6 @@
6363
node.default['bcpc']['hadoop']['hbase']['env']['HBASE_REGIONSERVER_OPTS'] =
6464
node['bcpc']['hadoop']['hbase']['env']['HBASE_REGIONSERVER_OPTS'] +
6565
' -XX:MaxDirectMemorySize=' + node['bcpc']['hadoop']['hbase_rs']['mx_dir_mem']['size'].to_s + 'm'
66-
67-
node.default['bcpc']['hadoop']['hbase']['env']['HBASE_MASTER_OPTS'] =
68-
node['bcpc']['hadoop']['hbase']['env']['HBASE_MASTER_OPTS'] +
69-
' -XX:MaxDirectMemorySize=' + node['bcpc']['hadoop']['hbase_master']['mx_dir_mem']['size'].to_s + 'm'
7066
end
7167

7268
if node[:bcpc][:hadoop][:kerberos][:enable] == true

0 commit comments

Comments
 (0)