Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CKV_GCP_125: check too big, not documented, cumbersome to satisfy #6981

Open
pndurette opened this issue Jan 28, 2025 · 2 comments
Open

CKV_GCP_125: check too big, not documented, cumbersome to satisfy #6981

pndurette opened this issue Jan 28, 2025 · 2 comments

Comments

@pndurette
Copy link

Describe the issue

CKV_GCP_125 has 8 possible failure cases with a very generic error ("Ensure GCP GitHub Actions OIDC trust policy is configured securely").

It just triggered for us on existing resources and it's very cumbersome to know what's up without any documentation. I have to go through the check source code line-by-line running the code in my head with my Terraform code next to it to try to see what it suddenly complains about.

Either it needs better explanation of what's being checked or it needs to be broken up in way more checks.

Examples
N/A

Version (please complete the following information):

  • Checkov Version 3.2.357 (from the GitHub Actions run log)

Additional context
N/A

@issacg
Copy link

issacg commented Feb 10, 2025

FWIW, this seems to have been introduced in #6964
The code used to be more verbose about the failure reason, and these printed reasons were prune from the code in the above PR. Perhaps this can be restored?

@dothomson
Copy link

I've also just encountered this issue.

Additionally the rule doesn't handle cases where the attribute condition is constructed using variables or locals.

I was providing the repo name via a module variable but will now have to disable to check as this rule is not specific and unclear on why it isn't working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants