Skip to content

Commit aa74853

Browse files
fix: remove global browserify transforms, so parent packages don't break (#48)
1 parent 3c76053 commit aa74853

File tree

3 files changed

+5
-9
lines changed

3 files changed

+5
-9
lines changed

package.json

+1-7
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,6 @@
99
"videojs",
1010
"videojs-plugin"
1111
],
12-
"browserify": {
13-
"transform": [
14-
"browserify-shim",
15-
"browserify-versionify"
16-
]
17-
},
1812
"browserify-shim": {
1913
"qunit": "global:QUnit",
2014
"sinon": "global:sinon",
@@ -38,7 +32,7 @@
3832
"build:js": "npm-run-all build:js:babel build:js:browserify build:js:bannerize build:js:uglify",
3933
"build:js:babel": "babel src -d es5",
4034
"build:js:bannerize": "bannerize dist/videojs-overlay.js --banner=scripts/banner.ejs",
41-
"build:js:browserify": "browserify . -s videojs-overlay -o dist/videojs-overlay.js",
35+
"build:js:browserify": "browserify . -s videojs-overlay -g browserify-shim -t browserify-versionify -o dist/videojs-overlay.js",
4236
"build:js:uglify": "uglifyjs dist/videojs-overlay.js --comments --mangle --compress -o dist/videojs-overlay.min.js",
4337
"build:test": "babel-node scripts/build-test.js",
4438
"build:test:browserify": "browserify `find test -name '*.test.js'` -t babelify -o dist-test/videojs-overlay.js",

scripts/build-test.js

+2
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ glob('test/**/*.test.js', (err, files) => {
1010
}
1111
browserify(files)
1212
.transform('babelify')
13+
.transform('browserify-shim', {global: true})
14+
.transform('browserify-versionify')
1315
.bundle()
1416
.pipe(fs.createWriteStream('test/dist/bundle.js'));
1517
});

scripts/server.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ const bundlers = {
3535
standalone: nameify('%s'),
3636
transform: [
3737
'babelify',
38-
'browserify-shim',
38+
['browserify-shim', {global: true}],
3939
'browserify-versionify'
4040
]
4141
}),
@@ -45,7 +45,7 @@ const bundlers = {
4545
entries: srces.tests,
4646
transform: [
4747
'babelify',
48-
'browserify-shim',
48+
['browserify-shim', {global: true}],
4949
'browserify-versionify'
5050
]
5151
})

0 commit comments

Comments
 (0)