chore: update build tooling to drop older browser support #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,30 +42,29 @@ | |||
| }, | |||
| "dependencies": { | |||
| "global": "^4.3.2", | |||
| "video.js": "^6 || ^7" | |||
| "video.js": "^6 || ^7 || ^8" | |||
There was a problem hiding this comment.
Are we certain we don't want to remove v6 here?
There was a problem hiding this comment.
Discussed offline and decided this can be considered in another PR
wseymour15
approved these changes
Dec 15, 2022
dzianis-dashkevich
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the default browserslist used by babel. It drops support for some older browsers including IE 11. This also removes the
browserslistin package.json so we use the default list from @videojs/babel-config (linked above). Additionally, this removesjsdocwhich was unused and pointing at a defunct repo, adds Video.js 8 as a compatible version, and a few other updates to enable these build changes.MUST be merged with
BREAKING CHANGEfooter. Requires new major version.