feat: move to advanced plugin and add reset API #224
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will be a breaking change, and we will need this to be a major version bump
Since the user will no longer be able to reset the options with the
player.overlay()
functionality after moving to an advanced plugin, we now have theoverlay.reset()
function to do something similar.These changes move the plugin from a function to an advanced plugin, giving the plugin lifecycle methods.
Specific Changes proposed
reset
function to update the plugin options and reset the overlays.videojs-overlay.plugin.js
to the dist so we have a way of importing this plugin class without registering/initializing it.Requirements Checklist