Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: package json export for publish #225

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

wseymour15
Copy link
Contributor

@wseymour15 wseymour15 commented Oct 28, 2024

Description

When attempting to publish the package, npm publish was giving me the following error:

Error in dist/videojs-overlay.cjs.js:
node:internal/modules/cjs/loader:641
      throw e;
      ^

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: No "exports" main defined in /private/var/folders/5f/.../node_modules/videojs-overlay/package.json

This change fixes the issue, and has been tested with dry-run

Specific Changes proposed

  • Add default exports to package.json

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Unit Tests updated or fixed
    • Docs/guides updated
  • Reviewed by Two Core Contributors

@wseymour15 wseymour15 merged commit 944acd6 into main Oct 28, 2024
@wseymour15 wseymour15 deleted the fix/package-json-exports branch October 28, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants