Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aria text is repeatedly set on containers of vs-constr, not on elements #582

Open
jpolitz opened this issue Feb 18, 2025 · 0 comments
Open

Comments

@jpolitz
Copy link
Member

jpolitz commented Feb 18, 2025

Consider

{ method _output(self): VS.vs-constr("thing", [list: VS.vs-str("abc"), VS.vs-str("def")]) end }

Right now constructed values don't have much aria text assigned to them. But there's an issue where vs-constr sends the same container in to helper, which then sets aria text for each vs-str on the container rather than having a separate container element for each string (or, in general, each component in the vs-constr).

The fix is probably to make a container for each sub-element at https://github.com/brownplt/code.pyret.org/blob/horizon/src/web/js/output-ui.js#L1692

Image

CC @sidprasad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant