Skip to content

Commit f0930c0

Browse files
committed
[Tests] skip some tests for a broken require.resolve in node v8.9, v9.0-v9.2
See nodejs/node#17113
1 parent 75d3bb9 commit f0930c0

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

.eslintrc

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"func-name-matching": 0,
1414
"func-style": 0,
1515
"global-require": 1,
16-
"id-length": [2, { "min": 1, "max": 30 }],
16+
"id-length": [2, { "min": 1, "max": 40 }],
1717
"max-lines": [2, 350],
1818
"max-lines-per-function": 0,
1919
"max-nested-callbacks": 0,

test/resolver_sync.js

+6-3
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ var sync = require('../sync');
88
var requireResolveSupportsPaths = require.resolve.length > 1
99
&& !(/^v12\.[012]\./).test(process.version); // broken in v12.0-12.2, see https://github.com/nodejs/node/issues/27794
1010

11+
var requireResolveDefaultPathsBroken = (/^v8\.9\.|^v9\.[01]\.0|^v9\.2\./).test(process.version);
12+
// broken in node v8.9.x, v9.0, v9.1, v9.2.x. see https://github.com/nodejs/node/pull/17113
13+
1114
test('`./sync` entry point', function (t) {
1215
t.equal(resolve.sync, sync, '`./sync` entry point is the same as `.sync` on `main`');
1316
t.end();
@@ -75,7 +78,7 @@ test('bar', function (t) {
7578
path.join(dir, 'bar/node_modules/foo/index.js'),
7679
'foo in bar'
7780
);
78-
if (requireResolveSupportsPaths) {
81+
if (!requireResolveDefaultPathsBroken && requireResolveSupportsPaths) {
7982
t.equal(
8083
resolve.sync('foo', { basedir: basedir }),
8184
require.resolve('foo', { paths: [basedir] }),
@@ -125,7 +128,7 @@ test('biz', function (t) {
125128
resolve.sync('tiv', { basedir: tivDir }),
126129
path.join(dir, 'tiv/index.js')
127130
);
128-
if (requireResolveSupportsPaths) {
131+
if (!requireResolveDefaultPathsBroken && requireResolveSupportsPaths) {
129132
t.equal(
130133
resolve.sync('tiv', { basedir: tivDir }),
131134
require.resolve('tiv', { paths: [tivDir] }),
@@ -138,7 +141,7 @@ test('biz', function (t) {
138141
resolve.sync('grux', { basedir: gruxDir }),
139142
path.join(dir, 'grux/index.js')
140143
);
141-
if (requireResolveSupportsPaths) {
144+
if (!requireResolveDefaultPathsBroken && requireResolveSupportsPaths) {
142145
t.equal(
143146
resolve.sync('grux', { basedir: gruxDir }),
144147
require.resolve('grux', { paths: [gruxDir] }),

0 commit comments

Comments
 (0)