You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think what needs to happen is to have two separate contexts / channels:
Used as it is today to block in FutureXXX to wait for Exec to run
A second that is closed inside of Discard and Close that marks all FutureXXX from that pipeline as invalid, rather than potentially returning invalid data / panicking as they would today
The text was updated successfully, but these errors were encountered:
At the beginning of the
Discard()
function, it checks to see if the context has been canceled and errors out if it hasolric/pipeline.go
Lines 441 to 448 in 4076aef
However the same context is canceled during
Exec()
, soDiscard()
will always return an error afterwards, which is its primary use caseolric/pipeline.go
Lines 405 to 416 in 4076aef
I think what needs to happen is to have two separate contexts / channels:
FutureXXX
to wait forExec
to runDiscard
andClose
that marks allFutureXXX
from that pipeline as invalid, rather than potentially returning invalid data / panicking as they would todayThe text was updated successfully, but these errors were encountered: