Skip to content
This repository was archived by the owner on Jun 13, 2022. It is now read-only.

Closing window bug #146

Closed
robhuska opened this issue Apr 11, 2018 · 9 comments
Closed

Closing window bug #146

robhuska opened this issue Apr 11, 2018 · 9 comments
Labels

Comments

@robhuska
Copy link

I know this seems odd, but I have gone through plugins one by one and I have found that this is definitely caused by flex-toolbar...

When flex-toolbar is Enabled and I close my Atom window I am working in, it does something I cannot really describe, but I have screenshots to show.

Before clicking "x" to close the window:
flex-toolbar-before-close

After I click the "x" to close the window:
flex-toolbar-after-close

So it looks like everything running within the window shuts down, but something stops it and leaves unstyled/unformatted code. Even if I Disable the Tool-Bar package and leave flex-toolbar Enabled, it still does this. It is only when I Disable flex-toolbar that this behavior stops.

macOS 10.13..4
Atom 1.25.1
flex-toolbar 2.0
tool-bar 1.1.7

Let me know if there is anything else I can do to help.

@UziTech
Copy link
Collaborator

UziTech commented Apr 11, 2018

Try this:

  1. open Atom
  2. open Dev Tools (Ctrl + Shift + i)
  3. open Console settings
    image
  4. Check "Preserve log"
  5. Reload Atom (Ctrl + Shift + F5)

You should get an error message that will be more descriptive.

I get the same thing occasionally from this bug: atom/grammar-selector#54

@robhuska
Copy link
Author

Just submitted this and flex-toolbar 2.0.1 showed up for an update. Does not fix the issue. But that reminds me, I cannot confirm right now, but I have a feeling this package is also causing Atom to not restart properly when installing updates. When I click a "Restart" button again Atom starts the process but stalls before completely shutting down, forcing me to have to quit from the Dock.

@robhuska
Copy link
Author

robhuska commented Apr 11, 2018

@UziTech Thank you, here is what I got.

Before Reload:
screen shot 2018-04-11 at 12 01 19 pm

After Reload:
screen shot 2018-04-11 at 12 02 42 pm

Maybe something to do with devicons? I am not using them in my config.

@UziTech
Copy link
Collaborator

UziTech commented Apr 11, 2018

Does this happen every time you close Atom when flex-toolbar is enabled?

@robhuska
Copy link
Author

Yes, as long as a file is opened.

@UziTech
Copy link
Collaborator

UziTech commented Apr 11, 2018

Try closing atom with dev tools open when it happens and see if there is a new error that shows up

@robhuska
Copy link
Author

@UziTech Good call!!
screen shot 2018-04-11 at 3 06 19 pm

@UziTech
Copy link
Collaborator

UziTech commented Apr 11, 2018

v2.0.2 should fix it. Thanks for reporting it! 💯

@robhuska
Copy link
Author

That appears to have done it! Thank you for the quick turn around! 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants