Skip to content

fix(setFormValue): accept empty strings like Chrome #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2021
Merged

fix(setFormValue): accept empty strings like Chrome #23

merged 1 commit into from
Feb 19, 2021

Conversation

lideen
Copy link
Contributor

@lideen lideen commented Feb 18, 2021

Found an inconsistency with Chrome. Chrome accepts empty strings in setFormValue the polyfill does not.

@calebdwilliams
Copy link
Owner

@lideen can you squash these commits?

@lideen
Copy link
Contributor Author

lideen commented Feb 18, 2021

Whoops.. squashed 😄

calebdwilliams
calebdwilliams approved these changes Feb 19, 2021
View reviewed changes
Copy link
Owner

@calebdwilliams calebdwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@calebdwilliams calebdwilliams merged commit 8f41892 into calebdwilliams:master Feb 19, 2021
@calebdwilliams
Copy link
Owner

This was released as version 0.1.18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebdwilliams calebdwilliams calebdwilliams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lideen @calebdwilliams