Skip to content

fix: add hidden input for lit-element after render completes #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 11, 2021

Conversation

brion-fuller
Copy link
Contributor

Lit-element rendering has issue with setting element before it does it's first update. You can see this best when creating a custom element that uses a select element underneath. Options for the select are rendered in plain text a few elements because the custom element.

This is framework specific so I don't know if this is something you would like in this polyfill.

@calebdwilliams calebdwilliams merged commit ebbb8ef into calebdwilliams:master Mar 11, 2021
@calebdwilliams
Copy link
Owner

This was released in 0.1.26. I didn't notice this until it was too late, but next time please don't modify the package name, version or publishConfig in PRs. This is open source so you're obviously welcome to use and modify the code as long as it's within the parameters of the license, but I was super confused why I couldn't publish for a bit.

@brion-fuller
Copy link
Contributor Author

Oh wow... sorry that was after I put the PR. Yeah that wasn’t supposed to come over. I’ll setup a branch next time.

@calebdwilliams
Copy link
Owner

Hey, no worries. If you don't mind me asking what's the second package for? Is it just to test and use before I merge/release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants