Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endless client job stream registration #13036

Closed
Tracked by #11231
npepinpe opened this issue Jun 9, 2023 · 1 comment · Fixed by #13062
Closed
Tracked by #11231

Endless client job stream registration #13036

npepinpe opened this issue Jun 9, 2023 · 1 comment · Fixed by #13062
Assignees
Labels
component/broker component/gateway kind/bug Categorizes an issue or PR as a bug severity/low Marks a bug as having little to no noticeable impact for the user version:8.3.0-alpha3 Marks an issue as being completely or in parts released in 8.3.0-alpha3 version:8.3.0 Marks an issue as being completely or in parts released in 8.3.0

Comments

@npepinpe
Copy link
Member

npepinpe commented Jun 9, 2023

Describe the bug

When registering a new client job stream from the gateway to any broker, the brokers are successfully registering the streams, but not responding to the gateway, causing the gateway to retry over and over.

While this still allows pushing, it creates a lot of noise and the impression that the streams are not successfully registered.

The underlying cause is the usage of the ClusterCommunicationService#subscribe(String, Function<byte[], M>, BiConsumer<MemberId, M>, Executor executor) - any subscriber which is a consumer will never send a response back. However, the client in this case expects a response.

Expected behavior

Client streams are properly registered on both sides.

@npepinpe npepinpe added kind/bug Categorizes an issue or PR as a bug severity/low Marks a bug as having little to no noticeable impact for the user component/gateway component/broker labels Jun 9, 2023
@npepinpe npepinpe self-assigned this Jun 9, 2023
@npepinpe
Copy link
Member Author

npepinpe commented Jun 9, 2023

One hurdle here is there's no easy way to introspect the registered client streams. So our tests were passing because we just check if the server has registered the stream (which it has), but we have no real way to catch that the client is in an endless loop.

@ghost ghost closed this as completed in 972e145 Jun 13, 2023
@ChrisKujawa ChrisKujawa added the version:8.3.0-alpha3 Marks an issue as being completely or in parts released in 8.3.0-alpha3 label Jul 6, 2023
@megglos megglos added the version:8.3.0 Marks an issue as being completely or in parts released in 8.3.0 label Oct 5, 2023
github-merge-queue bot pushed a commit that referenced this issue Aug 9, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/broker component/gateway kind/bug Categorizes an issue or PR as a bug severity/low Marks a bug as having little to no noticeable impact for the user version:8.3.0-alpha3 Marks an issue as being completely or in parts released in 8.3.0-alpha3 version:8.3.0 Marks an issue as being completely or in parts released in 8.3.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants