fix: more precise and reliable way to force new leaders in tests #10066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes two things: 1. after promoting a new leader, we assert that the new leader is as expected 2. retries the promote request to allow for temporary failures, for example unavailable receivers
ChrisKujawa
approved these changes
Aug 16, 2022
| .getServer(); | ||
|
|
||
| Awaitility.await("Promote request is successful") | ||
| .pollInterval(Duration.ofMillis(500)) |
There was a problem hiding this comment.
❓ Any specifc reason for that poll interval?
There was a problem hiding this comment.
Not at all, 500ms just felt like a reasonable interval before retrying 🤷
There was a problem hiding this comment.
Hm ok I would just remove it, otherwise it looks like it is important 🤷
qa/integration-tests/src/test/java/io/camunda/zeebe/it/clustering/ReaderCloseTest.java
Outdated
Show resolved
Hide resolved
|
Thanks @Zelldon! bors r+ |
ghost
pushed a commit
that referenced
this pull request
Aug 16, 2022
10066: fix: more precise and reliable way to force new leaders in tests r=oleschoenburg a=oleschoenburg ## Description This PR changes two things: 1. after promoting a new leader, we assert that the new leader is as expected 2. retries the promote request to allow for temporary failures, for example unavailable receivers ## Related issues <!-- Which issues are closed by this PR or are related --> closes #9921 Co-authored-by: Ole Schönburg <[email protected]>
|
Build failed: |
|
bors retry |
|
Build succeeded: |
ghost
merged commit 
|
Flaky on stable/8.0 still. Let me try backporting /backport |
|
Successfully created backport PR for |
ghost
pushed a commit
that referenced
this pull request
Jul 12, 2023
13453: [Backport stable/8.0] Limit error message size in job and incident records r=remcowesterhoud a=nicpuppa backport #12066 relates to #11460 13455: [Backport stable/8.0] fix: more precise and reliable way to force new leaders in tests r=remcowesterhoud a=backport-action # Description Backport of #10066 to `stable/8.0`. relates to #9921 Co-authored-by: camunda\berkay.can <[email protected]> Co-authored-by: Ole Schönburg <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes two things:
Related issues
closes #9921
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.