Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(.dependabot): stretch the open pr limits #12146

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

korthout
Copy link
Member

Description

Some dependencies are not being updated because we have too many pull requests by Dependabot open. We'll need to close/merge pull requests earlier, but we should also avoid missing out on dependency upgrades.

This stretches the limits as follows:

  • maven: 5 -> 25
  • go: 5 -> 10
  • gha: 5 -> 10

These are still just magic numbers, chosen at my personal whim. However, I feel that they better reflect our project. What numbers are optimal is hard to say. My thoughts are as follows:

  • we have many maven dependencies, so we should allow many open maven pull requests
  • we have fewer go and gha dependencies, so we don't need as many open pull requests for these dependencies

There is no way to disable the limit, AFAIK.
Any limit is a magically chosen number.
These numbers feel good to me.

Related issues

NA

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Other teams:
If the change impacts another team an issue has been created for this team, explaining what they need to do to support this change.

Please refer to our review guidelines.

Some dependencies are not being updated, because we have too many
pull requests by Dependabot open. We'll need to make sure to close/merge
pull requests earlier, but we should also avoid that we miss out on
dependency upgrades.

This stretches the limits as follows:
- maven: 5 -> 25
- go: 5 -> 10
- gha: 5 -> 10

These are still just magic numbers, chosen at my personal whim. However,
I feel that they better reflect our project. What numbers are optimal is
hard to say. My thoughts are as follows:
- we have many maven dependencies, we should allow many open maven pull
  requests
- we have fewer go and gha dependencies, we don't need as many open pull
  requests for these dependencies

There is no way to disable the limit AFAIK.
Any limit is a magically chosen number.
These numbers feel good to me.
@korthout korthout requested a review from saig0 March 27, 2023 16:35
@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2023

Test Results

1 042 files  ±    0  1 042 suites  ±0   1h 51m 17s ⏱️ - 5m 56s
8 517 tests +135  8 495 ✔️ +135  22 💤 ±0  0 ±0 
8 725 runs  +135  8 703 ✔️ +135  22 💤 ±0  0 ±0 

Results for commit d659ab4. ± Comparison against base commit 290e4ed.

This pull request removes 593 and adds 728 tests. Note that renamed tests count towards both.
DmnEvaluationTest If successfully evaluated, the output ‑ Should return a message pack output[6] value={z=[1, 2, 3], y=true, x=1}
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[56] collection=[Left[[B@1d3e5c4f]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[57] collection=[Right[[B@1d3e5c4f], Left[[B@1d3e5c4f]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[58] collection=[Left[[B@1d3e5c4f], Right[[B@1d3e5c4f]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[59] collection=[Left[[B@1d3e5c4f], Left[[B@1d3e5c4f]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[60] collection=[Right[[B@1d3e5c4f], Right[[B@1d3e5c4f], Left[[B@1d3e5c4f]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[61] collection=[Right[[B@1d3e5c4f], Left[[B@1d3e5c4f], Right[[B@1d3e5c4f]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[62] collection=[Right[[B@1d3e5c4f], Left[[B@1d3e5c4f], Left[[B@1d3e5c4f]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[63] collection=[Left[[B@1d3e5c4f], Right[[B@1d3e5c4f], Right[[B@1d3e5c4f]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[64] collection=[Left[[B@1d3e5c4f], Right[[B@1d3e5c4f], Left[[B@1d3e5c4f]]
…
DmnEvaluationTest If successfully evaluated, the output ‑ Should return a message pack output[6] value={x=1, z=[1, 2, 3], y=true}
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[56] collection=[Left[[B@5632b1e2]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[57] collection=[Right[[B@5632b1e2], Left[[B@5632b1e2]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[58] collection=[Left[[B@5632b1e2], Right[[B@5632b1e2]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[59] collection=[Left[[B@5632b1e2], Left[[B@5632b1e2]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[60] collection=[Right[[B@5632b1e2], Right[[B@5632b1e2], Left[[B@5632b1e2]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[61] collection=[Right[[B@5632b1e2], Left[[B@5632b1e2], Right[[B@5632b1e2]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[62] collection=[Right[[B@5632b1e2], Left[[B@5632b1e2], Left[[B@5632b1e2]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[63] collection=[Left[[B@5632b1e2], Right[[B@5632b1e2], Right[[B@5632b1e2]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[64] collection=[Left[[B@5632b1e2], Right[[B@5632b1e2], Left[[B@5632b1e2]]
…

♻️ This comment has been updated with latest results.

Copy link
Contributor

@megglos megglos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for taking care of this!

Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@korthout 👍

@saig0 saig0 merged commit 690e119 into main Mar 28, 2023
@saig0 saig0 deleted the korthout-stretch-dependabot-open-pr-limits branch March 28, 2023 06:16
@npepinpe npepinpe added the version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0 label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants