test(broker): wait until records are exported before taking snapshot #13039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The index of snapshot depends both on processed and exported positions. When the exporter is slow, the snapshot is taken at a different index, which resulted in flaky tests. To prevent flakiness, wait until all records are exported before taking the snapshot.
|
bors merge |
ghost
pushed a commit
that referenced
this pull request
Jun 12, 2023
13039: test(broker): wait until records are exported before taking snapshot r=deepthidevaki a=deepthidevaki ## Description The index of snapshot depends both on processed and exported positions. When the exporter is slow, the snapshot is taken at a different index, which resulted in flaky tests. To prevent flakiness, wait until all records are exported before taking the snapshot. Alternatively, we could disable exporter for this test. But this was not straightforward, as the recording exporter is part of the the rule. ## Related issues closes #12339 Co-authored-by: Deepthi Devaki Akkoorath <[email protected]>
|
Build failed: |
|
bors retry |
ghost
pushed a commit
that referenced
this pull request
Jun 12, 2023
13039: test(broker): wait until records are exported before taking snapshot r=deepthidevaki a=deepthidevaki ## Description The index of snapshot depends both on processed and exported positions. When the exporter is slow, the snapshot is taken at a different index, which resulted in flaky tests. To prevent flakiness, wait until all records are exported before taking the snapshot. Alternatively, we could disable exporter for this test. But this was not straightforward, as the recording exporter is part of the the rule. ## Related issues closes #12339 Co-authored-by: Deepthi Devaki Akkoorath <[email protected]>
|
Build failed: |
|
bors merge |
|
Build succeeded: |
ghost
merged commit 
|
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-13039-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-13039-to-stable/8.0
git checkout -b backport-13039-to-stable/8.0
ancref=$(git merge-base d166007d8fee3fa6f112367ea595d35199807f4f 1edc2a246ec51894e900505336d2ab6c7ff7c018)
git cherry-pick -x $ancref..1edc2a246ec51894e900505336d2ab6c7ff7c018 |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
ghost
pushed a commit
that referenced
this pull request
Jun 12, 2023
ghost
pushed a commit
that referenced
this pull request
Jun 12, 2023
lenaschoenburg
added
the
version:8.2.7
ghost
pushed a commit
that referenced
this pull request
Jun 14, 2023
ChrisKujawa
added
release/8.0.18
version:8.1.14
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 9, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The index of snapshot depends both on processed and exported positions. When the exporter is slow, the snapshot is taken at a different index, which resulted in flaky tests. To prevent flakiness, wait until all records are exported before taking the snapshot.
Alternatively, we could disable exporter for this test. But this was not straightforward, as the recording exporter is part of the the rule.
Related issues
closes #12339
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Other teams:
If the change impacts another team an issue has been created for this team, explaining what they need to do to support this change.
Please refer to our review guidelines.