Switch to software.xdev.saveactions IDEA plugin

[korthout]

Description

This project has been archived and is looking for a maintainer

This is the disclaimer at the top of the README of https://github.com/dubreuia/intellij-plugin-save-actions

The project was continued by fishermans in https://github.com/fishermans/intellij-plugin-save-actions, but they never published a new version on the IDEA Marketplace.

@xdev-software has now done this instead, which is the plugin version that this pull request switches to. Everyone still needs to accept the change by installing the newly required plugin. On start up, you'll notice an error pop-up informing you that you have not yet installed a required plugin.

This project seems nicely set up, with GHA to build and publish the version to the marketplace. They state that they will provide maintenance updates to provide support to newer IDEA versions. I had a look through the diff to look for obvious security problems, but did not encounter anything suspicious. I think we're good to use this instead.

See: dubreuia/intellij-plugin-save-actions#427
See: https://github.com/fishermans/intellij-plugin-save-actions
See: https://github.com/xdev-software/intellij-plugin-save-actions

Related issues

NA

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

• The changes are backwards compatibility with previous versions
• If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

• There are unit/integration tests that verify all acceptance criterias of the issue
• New tests are written to ensure backwards compatibility with further versions
• The behavior is tested manually
• The change has been verified by a QA run
• The impact of the changes is verified by a benchmark

Documentation:

• The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
• If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Other teams:
If the change impacts another team an issue has been created for this team, explaining what they need to do to support this change.

• Operate
• Tasklist
• Web Modeler
• Desktop Modeler
• Optimize

Please refer to our review guidelines.

[korthout]

When we merge this, we should update: https://github.com/camunda/zeebe/wiki/Code-Style

the save-actions plugin is pre-configured and required
the save-actions plugin is pre-configured and required

[npepinpe]

I was wondering if the built-in Actions on Save are not enough for us. I haven't tried it, so I don't know why we never went with that.

The plugin you added looks good to me 👍 I assume you tried it etc. 🚀

[korthout]

I was wondering if the built-in Actions on Save are not enough for us. I haven't tried it, so I don't know why we never went with that.

That's a good question to ask @npepinpe.

The reason is twofold:

• the configuration of Actions on Save is stored in .idea/workspace.xml, which should not be shared in a git repo (it's a personal config file), but we were always able to share our specific configuration through .idea/saveactions_settings.xml
• we currently use several options of the save actions plugin that, as far as I know, are not available in Actions on Save (I might be wrong about this one)

[korthout]

bors merge

[ghost]

Build succeeded:

• Test summary

[backport-action]

Backport failed for stable/8.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.0
git worktree add -d .worktree/backport-13326-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-13326-to-stable/8.0
git checkout -b backport-13326-to-stable/8.0
ancref=$(git merge-base b050dedcaf504368a58b96075962ab17a567db3a 1547888f6964984e213e0262c37ba5d8b1fe20f3)
git cherry-pick -x $ancref..1547888f6964984e213e0262c37ba5d8b1fe20f3

[backport-action]

Backport failed for stable/8.1, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.1
git worktree add -d .worktree/backport-13326-to-stable/8.1 origin/stable/8.1
cd .worktree/backport-13326-to-stable/8.1
git checkout -b backport-13326-to-stable/8.1
ancref=$(git merge-base b050dedcaf504368a58b96075962ab17a567db3a 1547888f6964984e213e0262c37ba5d8b1fe20f3)
git cherry-pick -x $ancref..1547888f6964984e213e0262c37ba5d8b1fe20f3

[backport-action]

Successfully created backport PR for stable/8.2:

• [Backport stable/8.2] Switch to software.xdev.saveactions IDEA plugin #13356