Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable TCC for integration tests #13404

Merged
1 commit merged into from
Jul 10, 2023
Merged

Temporarily disable TCC for integration tests #13404

1 commit merged into from
Jul 10, 2023

Conversation

npepinpe
Copy link
Member

@npepinpe npepinpe commented Jul 10, 2023

Description

This PR temporarily disables TCC usage, instead running container based tests directly on the same VM. This change has little impact on the actual Maven test time, and seems to stabilize the integration and update test modules.

I will reach out to TCC support in the mean time to figure out why it's so much flakier, even if we increase concurrency 🤷

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Other teams:
If the change impacts another team an issue has been created for this team, explaining what they need to do to support this change.

Please refer to our review guidelines.

@npepinpe npepinpe marked this pull request as ready for review July 10, 2023 11:48
@npepinpe npepinpe requested a review from ChrisKujawa July 10, 2023 11:48
Copy link
Member

@ChrisKujawa ChrisKujawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+ 🚀

@ghost
Copy link

ghost commented Jul 10, 2023

Build succeeded:

@ghost ghost merged commit 540db5c into main Jul 10, 2023
@ghost ghost deleted the np-disable-tcc branch July 10, 2023 12:07
@backport-action
Copy link
Collaborator

Backport failed for stable/8.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.0
git worktree add -d .worktree/backport-13404-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-13404-to-stable/8.0
git checkout -b backport-13404-to-stable/8.0
ancref=$(git merge-base 566607f992838c543a7feafce2dae787b8bd2baa 54b76ef5b9ea38f942f86233cfcf5dad08d4fc1a)
git cherry-pick -x $ancref..54b76ef5b9ea38f942f86233cfcf5dad08d4fc1a

@backport-action
Copy link
Collaborator

Successfully created backport PR for stable/8.1:

@backport-action
Copy link
Collaborator

Successfully created backport PR for stable/8.2:

ghost pushed a commit that referenced this pull request Jul 10, 2023
13406: [Backport stable/8.2] Temporarily disable TCC for integration tests r=npepinpe a=backport-action

# Description
Backport of #13404 to `stable/8.2`.

relates to 

Co-authored-by: Nicolas Pepin-Perreault <[email protected]>
ghost pushed a commit that referenced this pull request Jul 10, 2023
13405: [Backport stable/8.1] Temporarily disable TCC for integration tests r=npepinpe a=backport-action

# Description
Backport of #13404 to `stable/8.1`.

relates to 

Co-authored-by: Nicolas Pepin-Perreault <[email protected]>
ghost pushed a commit that referenced this pull request Jul 10, 2023
13407: [Backport stable/8.0] refactor: disable TCC for integration tests r=Zelldon a=npepinpe

## Description

This PR backports disabling TCC to 8.0.

(cherry picked from commit 54b76ef)

## Related issues

backports #13404 



Co-authored-by: Nicolas Pepin-Perreault <[email protected]>
@megglos megglos added version:8.2.9 Marks an issue as being completely or in parts released in 8.2.9 release/8.0.19 labels Jul 26, 2023
@abbasadel abbasadel added the version:8.1.15 Marks an issue as being completely or in parts released in 8.1.15 label Aug 2, 2023
github-merge-queue bot pushed a commit that referenced this pull request Aug 9, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version:8.1.15 Marks an issue as being completely or in parts released in 8.1.15 version:8.2.9 Marks an issue as being completely or in parts released in 8.2.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants