-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily disable TCC for integration tests #13404
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisKujawa
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+ 🚀
Build succeeded: |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-13404-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-13404-to-stable/8.0
git checkout -b backport-13404-to-stable/8.0
ancref=$(git merge-base 566607f992838c543a7feafce2dae787b8bd2baa 54b76ef5b9ea38f942f86233cfcf5dad08d4fc1a)
git cherry-pick -x $ancref..54b76ef5b9ea38f942f86233cfcf5dad08d4fc1a |
Successfully created backport PR for |
Successfully created backport PR for |
14 tasks
ghost
pushed a commit
that referenced
this pull request
Jul 10, 2023
13406: [Backport stable/8.2] Temporarily disable TCC for integration tests r=npepinpe a=backport-action # Description Backport of #13404 to `stable/8.2`. relates to Co-authored-by: Nicolas Pepin-Perreault <[email protected]>
ghost
pushed a commit
that referenced
this pull request
Jul 10, 2023
13405: [Backport stable/8.1] Temporarily disable TCC for integration tests r=npepinpe a=backport-action # Description Backport of #13404 to `stable/8.1`. relates to Co-authored-by: Nicolas Pepin-Perreault <[email protected]>
ghost
pushed a commit
that referenced
this pull request
Jul 10, 2023
13407: [Backport stable/8.0] refactor: disable TCC for integration tests r=Zelldon a=npepinpe ## Description This PR backports disabling TCC to 8.0. (cherry picked from commit 54b76ef) ## Related issues backports #13404 Co-authored-by: Nicolas Pepin-Perreault <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 9, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
version:8.1.15
Marks an issue as being completely or in parts released in 8.1.15
version:8.2.9
Marks an issue as being completely or in parts released in 8.2.9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR temporarily disables TCC usage, instead running container based tests directly on the same VM. This change has little impact on the actual Maven test time, and seems to stabilize the integration and update test modules.
I will reach out to TCC support in the mean time to figure out why it's so much flakier, even if we increase concurrency 🤷
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3
) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Other teams:
If the change impacts another team an issue has been created for this team, explaining what they need to do to support this change.
Please refer to our review guidelines.