fix(broker): report health on change only #13655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously every invocation of updateHealthStatus caused listeners to be called even if nothing changed.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| zeebePartitionHealth.addFailureListener(failureListener); | ||
|
|
||
| // when | ||
| partition.onNewRole(Role.LEADER, 1); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
There was a problem hiding this comment.
@oleschoenburg is there any alternative to this?
There was a problem hiding this comment.
No 😭 This is just the way it is currently and why the partition transition process needs some work.
|
bors merge |
ghost
pushed a commit
that referenced
this pull request
Jul 27, 2023
13655: fix(broker): report health on change only r=megglos a=megglos ## Description Previously every invocation of updateHealthStatus caused listeners to be called even if nothing changed. ## Related issues <!-- Which issues are closed by this PR or are related --> closes #13650 Co-authored-by: Meggle (Sebastian Bathke) <[email protected]>
|
Build failed: |
|
bors retry |
|
Build succeeded: |
ghost
merged commit 
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
ghost
pushed a commit
that referenced
this pull request
Jul 27, 2023
ghost
pushed a commit
that referenced
this pull request
Jul 27, 2023
ghost
pushed a commit
that referenced
this pull request
Jul 27, 2023
ghost
pushed a commit
that referenced
this pull request
Jul 27, 2023
megglos
added
version:8.2.10
abbasadel
added
the
version:8.1.15
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously every invocation of updateHealthStatus caused listeners to be called even if nothing changed.
Related issues
closes #13650
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing: