Introduce new commands to deploy resources in the Go client #8995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI stuff highlights some issues, but I think these are non issues: using a deprecated API (no way around it), and some duplicate code (I think that's fair for now, as we will replace the old deploy command eventually). |
Introduce a new `DeployResourceCommand` to the Go client API which to revert the previously committed breaking change. This means, in order to deploy DMN, users will have to use the new API. The old API is restored and will work as it previously used to.
Introduces a new sub command to the `deploy` command: `deploy resource`. This allows deploying resources, including DMN, making use of the new `DeployResourceCommand` API introduced in the client. Previous usages of the `deploy` command will work as before. The only caveat is if your filename was called purely `resource`, in which case you will get a proper error informing you about the new command.
npepinpe
force-pushed
the
np-fix-go-backwards-compat
branch
from
2362a53 to
8c2f307
Compare
|
bors merge |
|
@npepinpe I just noticed that the old API is not deprecated. Can you add this in a follow-up PR? |
|
Build succeeded:
|
ghost
merged commit
10 tasks
ghost
pushed a commit
that referenced
this pull request
Mar 28, 2022
8997: Mark DeployProcessCommand as deprecated for Go client r=npepinpe a=npepinpe ## Description This PR marks `DeployProcessCommand` as a deprecated method in the Go client, and also the `zbctl deploy <processPath>...` usage (to be replaced by `zbctl deploy resource <resourcePath>...`). Using the deprecated API in Go will trigger a warning (as you can see by our need to add `//nolint` in places 😄) ## Related issues related to #8995 Co-authored-by: Nicolas Pepin-Perreault <[email protected]>
ghost
pushed a commit
that referenced
this pull request
Mar 28, 2022
ghost
pushed a commit
that referenced
this pull request
Mar 28, 2022
ghost
pushed a commit
that referenced
this pull request
Mar 28, 2022
9002: [Backport release-8.0.0] Mark DeployProcessCommand as deprecated for Go client r=npepinpe a=github-actions[bot] # Description Backport of #8997 to `release-8.0.0`. relates to #8995 9007: [Backport release-8.0.0] Fix notification of snapshot replication listeners about missed events r=oleschoenburg a=oleschoenburg ## Description Manual backport of #8994 for the `8.0`release branch Co-authored-by: Nicolas Pepin-Perreault <[email protected]> Co-authored-by: Ole Schönburg <[email protected]>
deepthidevaki
added
the
version:8.1.0-alpha1
ChrisKujawa
added
the
version:8.1.0
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reverts the previous breaking changes and instead introduces new commands to deploy decisions and decision requirements. The client must now use
client.NewDeployResourceCommand(), and the oldclient.NewDeployProcessCommand()has been restored. Similarly,zbctlnow supports its oldzbctl deploy <path> <path>behavior, but also supportszbctl deploy resource mySuper.dmnas well, which behaves the same as the old deploy command but can deploy DMN files.Related issues
related to #8979
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation: