Add commit and record write quantile panels #8999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting for example for benchmark where we experiencing throughput issues overtime
|
npepinpe
approved these changes
Mar 29, 2022
| "pluginName": "Prometheus" | ||
| } | ||
| ], | ||
| "__requires": [ |
There was a problem hiding this comment.
🤔 Uh, this is new. I guess it's fine? 🤷♂️
There was a problem hiding this comment.
Yeah I guess so, at least I haven't added this :D
|
bors r+ |
ghost
pushed a commit
that referenced
this pull request
Mar 29, 2022
8977: Add random protocol record/value factory r=npepinpe a=npepinpe ## Description Adds a new utility to the `protocol-test-util` module which allows to generate random records and values in a deterministic way. Note that as data is randomly generated, the data has no meaning in itself - keys, positions, etc., are completely random. However, the `value` and `intent` are guaranteed to always be derived from the `valueType`. This is currently used to properly test the deserialization of the protocol via Jackson, but can later be used for exporter related unit tests. ## Related issues closes #8837 8999: Add commit and record write quantile panels r=Zelldon a=Zelldon ## Description Taking a look at performance issues often forces me at the end to look at the commit latencies, because of #8551 It is currently quite hard to compare latencies from two benchmarks, since this is show as a heatmap.  This PR should solve this issue, and allows me to not always recreate my panels (to see a difference). It addes two new panels, one for the commit latency and one for the record write latency. Both show the quantiles (p90, p99), the median and the avg. The formulars were based on : https://theswissbay.ch/pdf/Books/Computer%20science/prometheus_upandrunning.pdf (I use the book) The new panels look like this:  this allows to easier compare it to other benchmark which perform worse like:  <!-- Please explain the changes you made here. --> ## Related issues <!-- Which issues are closed by this PR or are related --> related to #8551 Co-authored-by: Nicolas Pepin-Perreault <[email protected]> Co-authored-by: Christopher Zell <[email protected]>
|
Build failed (retrying...): |
ghost
pushed a commit
that referenced
this pull request
Mar 29, 2022
8999: Add commit and record write quantile panels r=Zelldon a=Zelldon ## Description Taking a look at performance issues often forces me at the end to look at the commit latencies, because of #8551 It is currently quite hard to compare latencies from two benchmarks, since this is show as a heatmap.  This PR should solve this issue, and allows me to not always recreate my panels (to see a difference). It addes two new panels, one for the commit latency and one for the record write latency. Both show the quantiles (p90, p99), the median and the avg. The formulars were based on : https://theswissbay.ch/pdf/Books/Computer%20science/prometheus_upandrunning.pdf (I use the book) The new panels look like this:  this allows to easier compare it to other benchmark which perform worse like:  <!-- Please explain the changes you made here. --> ## Related issues <!-- Which issues are closed by this PR or are related --> related to #8551 9017: chore(maven): add trailing slashes to new Artifactory URL r=cmur2 a=cmur2 ## Description I got review feedback that it is recommended to have trailing slashes to the URL so I'm adding them for consistency. ## Related issues Related to INFRA-3107 Co-authored-by: Christopher Zell <[email protected]> Co-authored-by: Christian Nicolai <[email protected]>
|
Build failed (retrying...): |
ghost
pushed a commit
that referenced
this pull request
Mar 29, 2022
8999: Add commit and record write quantile panels r=Zelldon a=Zelldon ## Description Taking a look at performance issues often forces me at the end to look at the commit latencies, because of #8551 It is currently quite hard to compare latencies from two benchmarks, since this is show as a heatmap.  This PR should solve this issue, and allows me to not always recreate my panels (to see a difference). It addes two new panels, one for the commit latency and one for the record write latency. Both show the quantiles (p90, p99), the median and the avg. The formulars were based on : https://theswissbay.ch/pdf/Books/Computer%20science/prometheus_upandrunning.pdf (I use the book) The new panels look like this:  this allows to easier compare it to other benchmark which perform worse like:  <!-- Please explain the changes you made here. --> ## Related issues <!-- Which issues are closed by this PR or are related --> related to #8551 Co-authored-by: Christopher Zell <[email protected]>
|
Build failed: |
deepthidevaki
added
the
version:8.1.0-alpha1
ChrisKujawa
added
the
version:8.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Taking a look at performance issues often forces me at the end to look at the commit latencies, because of #8551 It is currently quite hard to compare latencies from two benchmarks, since this is show as a heatmap.
This PR should solve this issue, and allows me to not always recreate my panels (to see a difference).
It addes two new panels, one for the commit latency and one for the record write latency. Both show the quantiles (p90, p99), the median and the avg.
The formulars were based on : https://theswissbay.ch/pdf/Books/Computer%20science/prometheus_upandrunning.pdf (I use the book)
The new panels look like this:
this allows to easier compare it to other benchmark which perform worse like:
Related issues
related to #8551
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation: