-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(maven): add trailing slashes to new Artifactory URL #9017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaima-mnsr
approved these changes
Mar 29, 2022
bors merge |
ghost
pushed a commit
that referenced
this pull request
Mar 29, 2022
9017: chore(maven): add trailing slashes to new Artifactory URL r=cmur2 a=cmur2 ## Description I got review feedback that it is recommended to have trailing slashes to the URL so I'm adding them for consistency. ## Related issues Related to INFRA-3107 Co-authored-by: Christian Nicolai <[email protected]>
Build failed: |
bors retry |
ghost
pushed a commit
that referenced
this pull request
Mar 29, 2022
9009: deps(maven): bump rest-assured from 4.5.1 to 5.0.0 r=npepinpe a=dependabot[bot] Bumps [rest-assured](https://github.com/rest-assured/rest-assured) from 4.5.1 to 5.0.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/rest-assured/rest-assured/blob/master/changelog.txt">rest-assured's changelog</a>.</em></p> <blockquote> <h2>Changelog 5.0.0 (2022-03-25)</h2> <ul> <li>Breaking change: REST Assured now builds on Groovy 4!</li> <li>Excluded example projects from rest assured bom file (issue 1546)</li> <li>Updated jackson from version 2.11.1 to 2.13.2 (issue 1555)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rest-assured/rest-assured/commit/2e78356464152ee4b993935f282678ab15628170"><code>2e78356</code></a> [maven-release-plugin] prepare release rest-assured-5.0.0</li> <li><a href="https://github.com/rest-assured/rest-assured/commit/bffeefe4c238a0b1c1f1a8d16c227036eacfd7fd"><code>bffeefe</code></a> Updated jackson from version 2.11.1 to 2.13.2 (issue 1555)</li> <li><a href="https://github.com/rest-assured/rest-assured/commit/fd477c599724b19f7361cc12d581446d8eba19c1"><code>fd477c5</code></a> Excluded example projects from rest assured bom file (issue 1546)</li> <li><a href="https://github.com/rest-assured/rest-assured/commit/3a74c2c10745c295d09acce23728ba354d499a9b"><code>3a74c2c</code></a> Updated changelog to reflect the latest changes</li> <li><a href="https://github.com/rest-assured/rest-assured/commit/b505d4aaa402176ea70991cddf974bc033b01e46"><code>b505d4a</code></a> Trying ubuntu latest for github actions</li> <li><a href="https://github.com/rest-assured/rest-assured/commit/d7f0466911082a45b5efb57e33e150789085994d"><code>d7f0466</code></a> Upgrading sundrio plugin</li> <li><a href="https://github.com/rest-assured/rest-assured/commit/1bc199e79c47d47119096c38a4f6b75f95d280df"><code>1bc199e</code></a> Removed some redundant OSGi package imports and did a few minor other tweaks ...</li> <li><a href="https://github.com/rest-assured/rest-assured/commit/30a6c96a2cd176c81609f61d772f77b62ef74c16"><code>30a6c96</code></a> Removed downloads link</li> <li><a href="https://github.com/rest-assured/rest-assured/commit/24614440409d446abaf5bab30993b866ae8d16a4"><code>2461444</code></a> Fixes OSGi itests and corrects groovy import range (<a href="https://github-redirect.dependabot.com/rest-assured/rest-assured/issues/1562">#1562</a>)</li> <li><a href="https://github.com/rest-assured/rest-assured/commit/4aa8ba7ec09717dd20a32f81aee02cee2aefe0bb"><code>4aa8ba7</code></a> Only build RA on Java 8 since gmaven plugin doesn't seem to play well with 11...</li> <li>Additional commits viewable in <a href="https://github.com/rest-assured/rest-assured/compare/rest-assured-4.5.1...rest-assured-5.0.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> 9017: chore(maven): add trailing slashes to new Artifactory URL r=cmur2 a=cmur2 ## Description I got review feedback that it is recommended to have trailing slashes to the URL so I'm adding them for consistency. ## Related issues Related to INFRA-3107 Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Christian Nicolai <[email protected]>
Build failed (retrying...): |
ghost
pushed a commit
that referenced
this pull request
Mar 29, 2022
9017: chore(maven): add trailing slashes to new Artifactory URL r=cmur2 a=cmur2 ## Description I got review feedback that it is recommended to have trailing slashes to the URL so I'm adding them for consistency. ## Related issues Related to INFRA-3107 Co-authored-by: Christian Nicolai <[email protected]>
bors retry |
Already running a review |
Build failed: |
bors retry |
ghost
pushed a commit
that referenced
this pull request
Mar 29, 2022
8999: Add commit and record write quantile panels r=Zelldon a=Zelldon ## Description Taking a look at performance issues often forces me at the end to look at the commit latencies, because of #8551 It is currently quite hard to compare latencies from two benchmarks, since this is show as a heatmap.  This PR should solve this issue, and allows me to not always recreate my panels (to see a difference). It addes two new panels, one for the commit latency and one for the record write latency. Both show the quantiles (p90, p99), the median and the avg. The formulars were based on : https://theswissbay.ch/pdf/Books/Computer%20science/prometheus_upandrunning.pdf (I use the book) The new panels look like this:  this allows to easier compare it to other benchmark which perform worse like:  <!-- Please explain the changes you made here. --> ## Related issues <!-- Which issues are closed by this PR or are related --> related to #8551 9017: chore(maven): add trailing slashes to new Artifactory URL r=cmur2 a=cmur2 ## Description I got review feedback that it is recommended to have trailing slashes to the URL so I'm adding them for consistency. ## Related issues Related to INFRA-3107 Co-authored-by: Christopher Zell <[email protected]> Co-authored-by: Christian Nicolai <[email protected]>
Build failed (retrying...): |
@oleschoenburg can we do anything else apart from retrying? |
ghost
pushed a commit
that referenced
this pull request
Mar 29, 2022
9017: chore(maven): add trailing slashes to new Artifactory URL r=cmur2 a=cmur2 ## Description I got review feedback that it is recommended to have trailing slashes to the URL so I'm adding them for consistency. ## Related issues Related to INFRA-3107 Co-authored-by: Christian Nicolai <[email protected]>
If this run also fails I can merge directly, no risk of merge conflicts here. |
Build failed: |
Successfully created backport PR #9021 for |
Successfully created backport PR #9022 for |
ghost
pushed a commit
that referenced
this pull request
Mar 29, 2022
9021: [Backport stable/1.2] chore(maven): add trailing slashes to new Artifactory URL r=oleschoenburg a=github-actions[bot] # Description Backport of #9017 to `stable/1.2`. relates to Co-authored-by: Christian Nicolai <[email protected]>
ghost
pushed a commit
that referenced
this pull request
Mar 29, 2022
9022: [Backport stable/1.3] chore(maven): add trailing slashes to new Artifactory URL r=oleschoenburg a=github-actions[bot] # Description Backport of #9017 to `stable/1.3`. relates to Co-authored-by: Christian Nicolai <[email protected]>
ghost
pushed a commit
that referenced
this pull request
Mar 29, 2022
9022: [Backport stable/1.3] chore(maven): add trailing slashes to new Artifactory URL r=oleschoenburg a=github-actions[bot] # Description Backport of #9017 to `stable/1.3`. relates to Co-authored-by: Christian Nicolai <[email protected]>
ghost
pushed a commit
that referenced
this pull request
Mar 30, 2022
9008: [Backport stable/1.3] fix: don't wait for actor being submitted r=deepthidevaki a=oleschoenburg ## Description Manual backport of #8993 9022: [Backport stable/1.3] chore(maven): add trailing slashes to new Artifactory URL r=oleschoenburg a=github-actions[bot] # Description Backport of #9017 to `stable/1.3`. relates to Co-authored-by: Roman <[email protected]> Co-authored-by: Christian Nicolai <[email protected]>
ghost
pushed a commit
that referenced
this pull request
Mar 30, 2022
9022: [Backport stable/1.3] chore(maven): add trailing slashes to new Artifactory URL r=oleschoenburg a=github-actions[bot] # Description Backport of #9017 to `stable/1.3`. relates to Co-authored-by: Christian Nicolai <[email protected]>
ghost
pushed a commit
that referenced
this pull request
Apr 5, 2022
9022: [Backport stable/1.3] chore(maven): add trailing slashes to new Artifactory URL r=oleschoenburg a=github-actions[bot] # Description Backport of #9017 to `stable/1.3`. relates to Co-authored-by: Christian Nicolai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
version:1.2.12
Marks an issue as being completely or in parts released in 1.2.12
version:1.3.8
version:8.1.0-alpha1
Marks an issue as being completely or in parts released in 8.1.0-alpha1
version:8.1.0
Marks an issue as being completely or in parts released in 8.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I got review feedback that it is recommended to have trailing slashes to the URL so I'm adding them for consistency.
Related issues
Related to INFRA-3107