Archive JVM error dumps on failure #9223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can see the run where I added tests to crash the JVM. The artifacts have the right file and all. I added one test per job type, not to each module. I would revert it before merging. |
remcowesterhoud
requested changes
Apr 25, 2022
There was a problem hiding this comment.
@npepinpe I have some small comments. Please have a look at them 🙂
🔧 I think it would be nice to combine the archive jobs for test results and test errors into one instead of duplicating them. We can do this by specifying multiple paths: https://github.com/actions/upload-artifact#upload-using-multiple-paths-and-exclusions
Archives dump files generated by the JVM on crashes (e.g. SIGSEV, SIGBUS, etc.). This is particularly useful when dealing with native memory and running into unrecoverable crashes to get the stacktrace of the failing frame, as this is often not logged to standard out.
npepinpe
force-pushed
the
9129-archive-jvm-dumps
branch
from
3a61c2c to
97699be
Compare
|
👍 I merged the paths together. |
npepinpe
force-pushed
the
9129-archive-jvm-dumps
branch
from
97699be to
fc31091
Compare
|
bors merge |
ghost
pushed a commit
that referenced
this pull request
Apr 25, 2022
9223: Archive JVM error dumps on failure r=npepinpe a=npepinpe ## Description This PR adds an extra post step to archive JVM error dumps when the jobs have failed. This means archiving any file with the pattern `hs_err_*.log` produced by the job. Archiving dump files generated by the JVM on crashes (e.g. SIGSEV, SIGBUS, etc.). This is particularly useful when dealing with native memory and running into unrecoverable crashes to get the stacktrace of the failing frame, as this is often not logged to standard out. NOTE: the post steps are getting bigger, but there is a follow up issue to group these together. ## Related issues closes #9129 Co-authored-by: Nicolas Pepin-Perreault <[email protected]>
|
Build failed: |
|
As bors is silent at the moment, I'll just merge. It's silly to run the whole pipeline for something that has no impact on it 😄 |
deepthidevaki
added
the
version:8.1.0-alpha1
ChrisKujawa
added
the
version:8.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an extra post step to archive JVM error dumps when the jobs have failed. This means archiving any file with the pattern
hs_err_*.logproduced by the job.Archiving dump files generated by the JVM on crashes (e.g. SIGSEV, SIGBUS, etc.). This is particularly useful when dealing with native memory and running into unrecoverable crashes to get the stacktrace of the failing frame, as this is often not logged to standard out.
NOTE: the post steps are getting bigger, but there is a follow up issue to group these together.
Related issues
closes #9129
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.