Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flamenco does not understand multiple packages or series names #4

Open
mateusrodrigues opened this issue Aug 19, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@mateusrodrigues
Copy link
Member

When playing around with Flamenco, I noticed that the file control.dotnet8.jammy,mantic was being copied to the destination directory as is, as well as getting assigned a BuildTargetSpecificity score of 0.

By analyzing the code further, it looks like the if statements that determine whether a file defines a package or a series name does not yet handle multiple comma-separated names being defined in extensionName, e.g.

...
            if (SourceDirectory.BuildableTargets.PackageNames.Contains(extensionName))
            {
                packageNameIsDefined = true;
                matchesTarget = extensionName.Equals(BuildTarget.PackageName);
            }
            else if (SourceDirectory.BuildableTargets.SeriesNames.Contains(extensionName))
            {
                seriesNameIsDefined = true;
                matchesTarget = extensionName.Equals(BuildTarget.SeriesName);
            }
            else
            {
                fileName = file.Name;
                buildTargetSpecificity = 0;
                return true;
            }
...

So, for the example given in the beginning, SourceDirectory.BuildableTargets.SeriesName does not directly contain a value of jammy,mantic and will, therefore, yield false.

@mateusrodrigues mateusrodrigues added the bug Something isn't working label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant