fix(core): Tools.getProperty did return 'null' for falsy values, now returns the actual values

Author: caesarsol

Diff for: packages/core/src/tools.spec.ts

@@ -0,0 +1,39 @@
+import { Tools } from "./tools";
+
+describe("Tools.getProperty", () => {
+	it("works with a simple nested object containing a number > 0", () => {
+		const obj = { a: { b: { c: 5 } } };
+
+		expect(Tools.getProperty(obj, "a", "b", "c")).toEqual(5);
+	});
+
+	it("works with a simple nested object containing a 0", () => {
+		const obj = { a: { b: { c: 0 } } };
+
+		expect(Tools.getProperty(obj, "a", "b", "c")).toEqual(0);
+	});
+
+	it("works with a simple nested object containing `false`", () => {
+		const obj = { a: { b: { c: false } } };
+
+		expect(Tools.getProperty(obj, "a", "b", "c")).toEqual(false);
+	});
+
+	it("works with a simple nested object containing `true`", () => {
+		const obj = { a: { b: { c: true } } };
+
+		expect(Tools.getProperty(obj, "a", "b", "c")).toEqual(true);
+	});
+
+	it("works with a simple nested object containing a string", () => {
+		const obj = { a: { b: { c: "qwerty" } } };
+
+		expect(Tools.getProperty(obj, "a", "b", "c")).toEqual("qwerty");
+	});
+
+	it("works with a simple nested object containing an empty string", () => {
+		const obj = { a: { b: { c: "" } } };
+
+		expect(Tools.getProperty(obj, "a", "b", "c")).toEqual("");
+	});
+});

Diff for: packages/core/src/tools.ts

@@ -183,7 +183,7 @@ export namespace Tools {
 		let position = object;
 		if (position) {
 			for (const prop of propPath) {
-				if (position[prop]) {
+				if (position[prop] !== null && position[prop] !== undefined) {
 					position = position[prop];
 				} else {
 					return null;