Skip to content

Commit f65a084

Browse files
fix(core): fix gauge charts without a delta number (#680)
1 parent 4275bdd commit f65a084

File tree

1 file changed

+9
-6
lines changed
  • packages/core/src/components/graphs

1 file changed

+9
-6
lines changed

Diff for: packages/core/src/components/graphs/gauge.ts

+9-6
Original file line numberDiff line numberDiff line change
@@ -251,11 +251,13 @@ export class Gauge extends Component {
251251
const deltaFontSize = delta
252252
? Tools.getProperty(options, "gauge", "deltaFontSize")
253253
: () => 0;
254-
const numberFormatter = Tools.getProperty(
254+
255+
// use numberFormatter here only if there is a delta supplied
256+
const numberFormatter = delta ? Tools.getProperty(
255257
options,
256258
"gauge",
257259
"numberFormatter"
258-
);
260+
) : () => null;
259261

260262
const arrowSize = Tools.getProperty(options, "gauge", "deltaArrow", "size");
261263
const numberSpacing = Tools.getProperty(
@@ -275,15 +277,16 @@ export class Gauge extends Component {
275277
`translate(0, ${deltaFontSize(radius) + numberSpacing})`
276278
);
277279

278-
const deltaNumber = deltaGroup
279-
.selectAll("text.gauge-delta-number")
280-
.data(delta !== null ? [delta] : []);
280+
const deltaNumber = DOMUtils.appendOrSelect(deltaGroup, "text.gauge-delta-number");
281+
282+
deltaNumber
283+
.data(delta === null ? [] : [delta]);
281284

282285
deltaNumber
283286
.enter()
284287
.append("text")
288+
.classed("gauge-delta-number", true)
285289
.merge(deltaNumber)
286-
.attr("class", "gauge-delta-number")
287290
.attr("text-anchor", "middle")
288291
.style("font-size", `${deltaFontSize(radius)}px`)
289292
.text((d) => `${numberFormatter(d)}%`);

0 commit comments

Comments
 (0)