fix(core): fix backwards compatibility for pie/donut #576

natashadecoste · 2020-04-14T19:42:29Z

Updates

if the data is return in tabular format, the pie model reassigns the group value to key value
if the dataset name is not provided, the data is the same (group and key values are both slice labels)

Demo screenshot or recording

data

export const pieData = {
	labels: ["2V2N 9KYPM version 1", "L22I P66EP L22I P66EP L22I P66EP", "JQAI 2M4L1", "J9DZ F37AP",
		"YEL48 Q6XK YEL48", "P66EP L22I L22I"],
	datasets: [
		{
			label: "Dataset 1",
			data: [20000, 65000, 75000, 1200, 10000, 25000]
		}
	]
};

before

after

Review checklist (for reviewers only)

…bular

netlify · 2020-04-14T19:47:23Z

Deploy preview for carbon-charts-vue ready!

Built with commit cc3762e

https://deploy-preview-576--carbon-charts-vue.netlify.app

netlify · 2020-04-14T19:47:53Z

Deploy preview for carbon-charts-angular ready!

Built with commit cc3762e

https://deploy-preview-576--carbon-charts-angular.netlify.app

netlify · 2020-04-14T19:48:41Z

Deploy preview for carbon-charts-react ready!

Built with commit cc3762e

https://deploy-preview-576--carbon-charts-react.netlify.app

theiliad · 2020-04-14T20:15:38Z

packages/core/src/model-pie.ts

+				}
+			});
+		}
+


all of this should go into this.getTabularData() in model-pie.ts, first calling super. getTabularData() then applying the rest of the additions

sounds good!

cal-smith

LGTM Barring the other comments 👍

…on-charts into pie-model-tabular

cal-smith

🎉

…ystem#576) * fix(core): fix pie model to ignore dataset name when converting to tabular * apply review changes

* Radar setup * Radar: create center and spokes * Radar refactor * Radar: Do not render anything if width or height are 0 * Radar: create blobs (wip) * Radar: set colors * Radar: refactor * Radar: create x axes * Radar: refactor * Radar: fix color opacity * Radar: Compute ticks with a minimum value * Radar: draw y axis * Radar: y axes start from the min tick value * Radar: add exit for x axes * Radar: blob creation refactor * Radar: rename classes * Radar: fix class name * Radar: mini refactor * Radar: fix blobs bind * Radar: style changes * Radar: fix min radius logic * Radar: bind displayData to x axes not data * Radar: add transitions * Radar: add key labels (wip) * Radar: change margin value * Radar: fix labels position * fix(core): fix backwards compatibility for pie/donut (#576) * fix(core): fix pie model to ignore dataset name when converting to tabular * apply review changes * provide all datapoint info to stacked bar tooltips (#573) * Merge pull request #574 from theiliad/axis-formatters * optimize axis tick formatting * Update packages/core/src/components/axes/axis.ts Co-Authored-By: natashadecoste <[email protected]> * optimize axis formatter for time-scale when user has already provided one Co-authored-by: natashadecoste <[email protected]> * v0.30.12 * fix(core): Support for Horizontal Line and Scatter Chart * fix line graph update issues * v0.30.13 * Change method name * v0.30.14 * Fix linting problem about methods order * v0.30.15 * Radar: fix y axes transitions * Code comments for tools.ts (#416) * update documentation for tools.ts * docs(tools.ts): api documentation Co-authored-by: Eliad Moosavi <[email protected]> * remove bbox dependency on pie labels * Merge pull request #588 from accurat/invalid-time-value-bug * Fix bug `RangeError Invalid time value` * Extends domain refactor * Time series: add example with addSpaceOnEdge = 0 * Rename functions * Change method order * v0.30.16 * v0.30.17 * Radar: use the new .join d3 method * Use join to manage enter, update, exit logic * Radar: fill missing data * Radar: fix animations but need a refactor * Radar: add events * Radar: add tooltip * Radar: miss an import * Radar: use groupMapsTo * Radar: number of spokes doesn't change * Radar: use groupMapsTo for data mapping * Radar: show NA when data are missing * Radar: add y labels * Radar: remove events on blobs * Radar: left align * Radar: create rectangles over x axis * Radar: make x axis dashed on mouse over * Radar: add dots * Radar: move utility functions in another file * Radar: fix radial label placement for negative angles * Radar: refactor * Radar: radialLabelPlacement refactor * Radar: better logic to center chart * Radar: fix x axis style when overed * Radar: change blobs opacity * Radar: create y axes transition * Radar: create x axes transition * Radar: create blobs transition * Radar: x and y labels transition * Radar: fix transitions * Radar: more left space for y labels * Radar: remove unused imports * Radar: use the right transitions * Radar: remove logs * Radar: remove debug stuff * Radar: update y labels * Radar: fix Firefox bug * Radar: move constants to configuration * Radar: rename variables * Radar: fix typo * Radar: update comments * Radar: move lodash methods inside Tools * Radar: add examples and make radar more generic * Radar: fix tooltip value * Radar: fix tooltip data order * Radar: fix radar default formatter * Radar: fix showing dots * Radar: use variable instead of recompute value * Radar: create enums from textAnchor and dominantBaseline values * Radar: put dots radius to radar configuration * Radar: use tabs instead of spaces * Radar: use helper function for accesing properties * Radar: get property from options Co-authored-by: natashadecoste <[email protected]> Co-authored-by: Eliad Moosavi <[email protected]> Co-authored-by: carbon-bot <[email protected]> Co-authored-by: Serena Girardi <[email protected]> Co-authored-by: Eliad Moosavi <[email protected]>

* Radar setup * Radar: create center and spokes * Radar refactor * Radar: Do not render anything if width or height are 0 * Radar: create blobs (wip) * Radar: set colors * Radar: refactor * Radar: create x axes * Radar: refactor * Radar: fix color opacity * Radar: Compute ticks with a minimum value * Radar: draw y axis * Radar: y axes start from the min tick value * Radar: add exit for x axes * Radar: blob creation refactor * Radar: rename classes * Radar: fix class name * Radar: mini refactor * Radar: fix blobs bind * Radar: style changes * Radar: fix min radius logic * Radar: bind displayData to x axes not data * Radar: add transitions * Radar: add key labels (wip) * Radar: change margin value * Radar: fix labels position * fix(core): fix backwards compatibility for pie/donut (carbon-design-system#576) * fix(core): fix pie model to ignore dataset name when converting to tabular * apply review changes * provide all datapoint info to stacked bar tooltips (carbon-design-system#573) * Merge pull request carbon-design-system#574 from theiliad/axis-formatters * optimize axis tick formatting * Update packages/core/src/components/axes/axis.ts Co-Authored-By: natashadecoste <[email protected]> * optimize axis formatter for time-scale when user has already provided one Co-authored-by: natashadecoste <[email protected]> * v0.30.12 * fix(core): Support for Horizontal Line and Scatter Chart * fix line graph update issues * v0.30.13 * Change method name * v0.30.14 * Fix linting problem about methods order * v0.30.15 * Radar: fix y axes transitions * Code comments for tools.ts (carbon-design-system#416) * update documentation for tools.ts * docs(tools.ts): api documentation Co-authored-by: Eliad Moosavi <[email protected]> * remove bbox dependency on pie labels * Merge pull request carbon-design-system#588 from accurat/invalid-time-value-bug * Fix bug `RangeError Invalid time value` * Extends domain refactor * Time series: add example with addSpaceOnEdge = 0 * Rename functions * Change method order * v0.30.16 * v0.30.17 * Radar: use the new .join d3 method * Use join to manage enter, update, exit logic * Radar: fill missing data * Radar: fix animations but need a refactor * Radar: add events * Radar: add tooltip * Radar: miss an import * Radar: use groupMapsTo * Radar: number of spokes doesn't change * Radar: use groupMapsTo for data mapping * Radar: show NA when data are missing * Radar: add y labels * Radar: remove events on blobs * Radar: left align * Radar: create rectangles over x axis * Radar: make x axis dashed on mouse over * Radar: add dots * Radar: move utility functions in another file * Radar: fix radial label placement for negative angles * Radar: refactor * Radar: radialLabelPlacement refactor * Radar: better logic to center chart * Radar: fix x axis style when overed * Radar: change blobs opacity * Radar: create y axes transition * Radar: create x axes transition * Radar: create blobs transition * Radar: x and y labels transition * Radar: fix transitions * Radar: more left space for y labels * Radar: remove unused imports * Radar: use the right transitions * Radar: remove logs * Radar: remove debug stuff * Radar: update y labels * Radar: fix Firefox bug * Radar: move constants to configuration * Radar: rename variables * Radar: fix typo * Radar: update comments * Radar: move lodash methods inside Tools * Radar: add examples and make radar more generic * Radar: fix tooltip value * Radar: fix tooltip data order * Radar: fix radar default formatter * Radar: fix showing dots * Radar: use variable instead of recompute value * Radar: create enums from textAnchor and dominantBaseline values * Radar: put dots radius to radar configuration * Radar: use tabs instead of spaces * Radar: use helper function for accesing properties * Radar: get property from options Co-authored-by: natashadecoste <[email protected]> Co-authored-by: Eliad Moosavi <[email protected]> Co-authored-by: carbon-bot <[email protected]> Co-authored-by: Serena Girardi <[email protected]> Co-authored-by: Eliad Moosavi <[email protected]>

* Time series: add example to show the bug about labels * Time series: fix bug about labels * Revert "Time series: fix bug about labels" This reverts commit 7c055fe. * Fix linter problems * Fix logic computing timeIntervalName * Rename variables inside closestTimeIntervalName function * Time series axis: use scale nice * Remove useless demo example * fix scatter interface * v0.30.18 * Ruler interaction replacing Grid mouse listeners for comparative tooltips (#499) * add ruler and axis tooltip * move ruler logic to it's own graphFrameComponent * refactor, add axis tooltip dynamic width, add matching elements hovering * use getDomainValue instead of hardcoded accessor * add snap to nearest point * use getSVGElementSize to get backdrop height * remove useless code * add trigger mouseout in hideRuler to only highlight single hovered element * WIP * fix categorical scale elements mouseover trigger * fix close points mouseover/out trigger * fix import order and package version * add more test data * add crosshair cursor when ruler is active to better select data points * refactor, more docs * fix axis tooltip baseline * minor refactor Co-Authored-By: Zvonimir Fras <[email protected]> * change ruler color * a11y bubble * only show ruler for continuous domain - wip * add support for top axis * no need to support discrete scales anymore * make sure tooltip does not go out of axis bbox * remove axis tooltip * only show ruler if there's match with data points * only show ruler on timescale linechart * add filter for items getting null values at times, breaking tooltip * refactor * fix(core): update import path carbon-components fix #546 * v0.30.7 * Merge pull request #529 from theiliad/tabular-data-format * add basic tabular data format support * string updates * finalize line graph implementation with tabular data support * cleanup * finalize scatter graph with support for tabular data * commented out ideas for the data format * time-series support for tabular data within line graph * scatter support * optimize logic to find main vertical & horizontal axes * remove primary & secondary labels * bubble chart support * grouped bar support * horizontal grouped bar * fix legend filtering * fix bubble and scatter * fix bar hover errors * simple bar support * simple bar time-series support * horizontal simple bar support * more graph support * fix pie tooltip * fix donut center value * fix line & scatter demo ranges * fix bar demos * stacked data supprot * backwards data format compatibility * fix plotting of datums with a value of 0 * fixed stacked bar tooltip * remove primary, secondary, useAsGraphDomain/Range * Update packages/core/src/model.ts Co-Authored-By: natashadecoste <[email protected]> * apply suggested PR changes * fix group bar positioning issues * apply PR suggested changes * Update packages/core/demo/data/bar.ts Co-Authored-By: natashadecoste <[email protected]> * Update packages/core/demo/data/bar.ts Co-Authored-By: natashadecoste <[email protected]> * Update packages/core/demo/data/bar.ts Co-Authored-By: natashadecoste <[email protected]> * rename "identifier" to "mapsTo" * add tutorials section to core storybook * add links to errors * remove unnecessary comment * add custom color scale support * apply PR suggested changes * fix tests Co-authored-by: natashadecoste <[email protected]> * v0.30.8 * Apply suggestions from code review Co-Authored-By: Eliad Moosavi <[email protected]> * applied suggestions from review * fix ruler css * Update packages/core/src/components/axes/ruler.ts Co-Authored-By: Eliad Moosavi <[email protected]> * Update packages/core/src/styles/components/_ruler.scss Co-Authored-By: Eliad Moosavi <[email protected]> * Update packages/core/src/components/axes/ruler.ts Co-Authored-By: Eliad Moosavi <[email protected]> * add suggestions from review * Update packages/core/demo/data/line.ts Co-Authored-By: natashadecoste <[email protected]> * Apply suggestions from code review Co-Authored-By: natashadecoste <[email protected]> * enable ruler on bubble and scatter * disable mouse listeners on grid * enable ruler for every scale type * fix ruler on linear scales, refactor matches logic Co-authored-by: Zvonimir Fras <[email protected]> Co-authored-by: Natasha DeCoste <[email protected]> Co-authored-by: carbon-bot <[email protected]> Co-authored-by: Eliad Moosavi <[email protected]> * Ruler fix (#598) * fix elements highlighting * fix multiple matching points * refactor * dead code * fix type * refactor reducer logic * more dead code * Update packages/core/src/components/axes/ruler.ts Co-Authored-By: Eliad Moosavi <[email protected]> * apply suggestion from review * rename * add orientation support * fix wrong y offset in mouse coords * better typing Co-authored-by: Eliad Moosavi <[email protected]> * fix vue type check for charting data * Add Svelte wrappers (#569) * feat: add svelte wrappers * chore(svelte): format babelrc, rollup config * chore(deps-dev): lock @storybook/svelte version Co-Authored-By: Eliad Moosavi <[email protected]> * chore(deps-dev): lock svelte version Co-Authored-By: Eliad Moosavi <[email protected]> * chore(deps-dev): lock svelte-loader version Co-Authored-By: Eliad Moosavi <[email protected]> * docs(svelte): fill in Codesandbox section * chore(svelte): define maintainers, contributors in package.json * docs(svelte): add codesandbox * chore(svelte): update package version to 0.30.18 Co-Authored-By: Eliad Moosavi <[email protected]> * chore(yarn): rebuild lockfile to fix errored ci Co-authored-by: Eliad Moosavi <[email protected]> * Update README.md * v0.30.19 * Merge pull request #581 from accurat/radar * Radar setup * Radar: create center and spokes * Radar refactor * Radar: Do not render anything if width or height are 0 * Radar: create blobs (wip) * Radar: set colors * Radar: refactor * Radar: create x axes * Radar: refactor * Radar: fix color opacity * Radar: Compute ticks with a minimum value * Radar: draw y axis * Radar: y axes start from the min tick value * Radar: add exit for x axes * Radar: blob creation refactor * Radar: rename classes * Radar: fix class name * Radar: mini refactor * Radar: fix blobs bind * Radar: style changes * Radar: fix min radius logic * Radar: bind displayData to x axes not data * Radar: add transitions * Radar: add key labels (wip) * Radar: change margin value * Radar: fix labels position * fix(core): fix backwards compatibility for pie/donut (#576) * fix(core): fix pie model to ignore dataset name when converting to tabular * apply review changes * provide all datapoint info to stacked bar tooltips (#573) * Merge pull request #574 from theiliad/axis-formatters * optimize axis tick formatting * Update packages/core/src/components/axes/axis.ts Co-Authored-By: natashadecoste <[email protected]> * optimize axis formatter for time-scale when user has already provided one Co-authored-by: natashadecoste <[email protected]> * v0.30.12 * fix(core): Support for Horizontal Line and Scatter Chart * fix line graph update issues * v0.30.13 * Change method name * v0.30.14 * Fix linting problem about methods order * v0.30.15 * Radar: fix y axes transitions * Code comments for tools.ts (#416) * update documentation for tools.ts * docs(tools.ts): api documentation Co-authored-by: Eliad Moosavi <[email protected]> * remove bbox dependency on pie labels * Merge pull request #588 from accurat/invalid-time-value-bug * Fix bug `RangeError Invalid time value` * Extends domain refactor * Time series: add example with addSpaceOnEdge = 0 * Rename functions * Change method order * v0.30.16 * v0.30.17 * Radar: use the new .join d3 method * Use join to manage enter, update, exit logic * Radar: fill missing data * Radar: fix animations but need a refactor * Radar: add events * Radar: add tooltip * Radar: miss an import * Radar: use groupMapsTo * Radar: number of spokes doesn't change * Radar: use groupMapsTo for data mapping * Radar: show NA when data are missing * Radar: add y labels * Radar: remove events on blobs * Radar: left align * Radar: create rectangles over x axis * Radar: make x axis dashed on mouse over * Radar: add dots * Radar: move utility functions in another file * Radar: fix radial label placement for negative angles * Radar: refactor * Radar: radialLabelPlacement refactor * Radar: better logic to center chart * Radar: fix x axis style when overed * Radar: change blobs opacity * Radar: create y axes transition * Radar: create x axes transition * Radar: create blobs transition * Radar: x and y labels transition * Radar: fix transitions * Radar: more left space for y labels * Radar: remove unused imports * Radar: use the right transitions * Radar: remove logs * Radar: remove debug stuff * Radar: update y labels * Radar: fix Firefox bug * Radar: move constants to configuration * Radar: rename variables * Radar: fix typo * Radar: update comments * Radar: move lodash methods inside Tools * Radar: add examples and make radar more generic * Radar: fix tooltip value * Radar: fix tooltip data order * Radar: fix radar default formatter * Radar: fix showing dots * Radar: use variable instead of recompute value * Radar: create enums from textAnchor and dominantBaseline values * Radar: put dots radius to radar configuration * Radar: use tabs instead of spaces * Radar: use helper function for accesing properties * Radar: get property from options Co-authored-by: natashadecoste <[email protected]> Co-authored-by: Eliad Moosavi <[email protected]> Co-authored-by: carbon-bot <[email protected]> Co-authored-by: Serena Girardi <[email protected]> Co-authored-by: Eliad Moosavi <[email protected]> * v0.30.20 Co-authored-by: Fei <[email protected]> Co-authored-by: carbon-bot <[email protected]> Co-authored-by: Luca Falasco <[email protected]> Co-authored-by: Zvonimir Fras <[email protected]> Co-authored-by: Natasha DeCoste <[email protected]> Co-authored-by: Eliad Moosavi <[email protected]> Co-authored-by: Eliad Moosavi <[email protected]> Co-authored-by: Eric Liu <[email protected]> Co-authored-by: Serena Girardi <[email protected]>

…ystem#576) * fix(core): fix pie model to ignore dataset name when converting to tabular * apply review changes

* Radar setup * Radar: create center and spokes * Radar refactor * Radar: Do not render anything if width or height are 0 * Radar: create blobs (wip) * Radar: set colors * Radar: refactor * Radar: create x axes * Radar: refactor * Radar: fix color opacity * Radar: Compute ticks with a minimum value * Radar: draw y axis * Radar: y axes start from the min tick value * Radar: add exit for x axes * Radar: blob creation refactor * Radar: rename classes * Radar: fix class name * Radar: mini refactor * Radar: fix blobs bind * Radar: style changes * Radar: fix min radius logic * Radar: bind displayData to x axes not data * Radar: add transitions * Radar: add key labels (wip) * Radar: change margin value * Radar: fix labels position * fix(core): fix backwards compatibility for pie/donut (carbon-design-system#576) * fix(core): fix pie model to ignore dataset name when converting to tabular * apply review changes * provide all datapoint info to stacked bar tooltips (carbon-design-system#573) * Merge pull request carbon-design-system#574 from theiliad/axis-formatters * optimize axis tick formatting * Update packages/core/src/components/axes/axis.ts Co-Authored-By: natashadecoste <[email protected]> * optimize axis formatter for time-scale when user has already provided one Co-authored-by: natashadecoste <[email protected]> * v0.30.12 * fix(core): Support for Horizontal Line and Scatter Chart * fix line graph update issues * v0.30.13 * Change method name * v0.30.14 * Fix linting problem about methods order * v0.30.15 * Radar: fix y axes transitions * Code comments for tools.ts (carbon-design-system#416) * update documentation for tools.ts * docs(tools.ts): api documentation Co-authored-by: Eliad Moosavi <[email protected]> * remove bbox dependency on pie labels * Merge pull request carbon-design-system#588 from accurat/invalid-time-value-bug * Fix bug `RangeError Invalid time value` * Extends domain refactor * Time series: add example with addSpaceOnEdge = 0 * Rename functions * Change method order * v0.30.16 * v0.30.17 * Radar: use the new .join d3 method * Use join to manage enter, update, exit logic * Radar: fill missing data * Radar: fix animations but need a refactor * Radar: add events * Radar: add tooltip * Radar: miss an import * Radar: use groupMapsTo * Radar: number of spokes doesn't change * Radar: use groupMapsTo for data mapping * Radar: show NA when data are missing * Radar: add y labels * Radar: remove events on blobs * Radar: left align * Radar: create rectangles over x axis * Radar: make x axis dashed on mouse over * Radar: add dots * Radar: move utility functions in another file * Radar: fix radial label placement for negative angles * Radar: refactor * Radar: radialLabelPlacement refactor * Radar: better logic to center chart * Radar: fix x axis style when overed * Radar: change blobs opacity * Radar: create y axes transition * Radar: create x axes transition * Radar: create blobs transition * Radar: x and y labels transition * Radar: fix transitions * Radar: more left space for y labels * Radar: remove unused imports * Radar: use the right transitions * Radar: remove logs * Radar: remove debug stuff * Radar: update y labels * Radar: fix Firefox bug * Radar: move constants to configuration * Radar: rename variables * Radar: fix typo * Radar: update comments * Radar: move lodash methods inside Tools * Radar: add examples and make radar more generic * Radar: fix tooltip value * Radar: fix tooltip data order * Radar: fix radar default formatter * Radar: fix showing dots * Radar: use variable instead of recompute value * Radar: create enums from textAnchor and dominantBaseline values * Radar: put dots radius to radar configuration * Radar: use tabs instead of spaces * Radar: use helper function for accesing properties * Radar: get property from options Co-authored-by: natashadecoste <[email protected]> Co-authored-by: Eliad Moosavi <[email protected]> Co-authored-by: carbon-bot <[email protected]> Co-authored-by: Serena Girardi <[email protected]> Co-authored-by: Eliad Moosavi <[email protected]>

…labels-bug * Time series: add example to show the bug about labels * Time series: fix bug about labels * Revert "Time series: fix bug about labels" This reverts commit 7c055fe. * Fix linter problems * Fix logic computing timeIntervalName * Rename variables inside closestTimeIntervalName function * Time series axis: use scale nice * Remove useless demo example * fix scatter interface * v0.30.18 * Ruler interaction replacing Grid mouse listeners for comparative tooltips (carbon-design-system#499) * add ruler and axis tooltip * move ruler logic to it's own graphFrameComponent * refactor, add axis tooltip dynamic width, add matching elements hovering * use getDomainValue instead of hardcoded accessor * add snap to nearest point * use getSVGElementSize to get backdrop height * remove useless code * add trigger mouseout in hideRuler to only highlight single hovered element * WIP * fix categorical scale elements mouseover trigger * fix close points mouseover/out trigger * fix import order and package version * add more test data * add crosshair cursor when ruler is active to better select data points * refactor, more docs * fix axis tooltip baseline * minor refactor Co-Authored-By: Zvonimir Fras <[email protected]> * change ruler color * a11y bubble * only show ruler for continuous domain - wip * add support for top axis * no need to support discrete scales anymore * make sure tooltip does not go out of axis bbox * remove axis tooltip * only show ruler if there's match with data points * only show ruler on timescale linechart * add filter for items getting null values at times, breaking tooltip * refactor * fix(core): update import path carbon-components fix carbon-design-system#546 * v0.30.7 * Merge pull request carbon-design-system#529 from theiliad/tabular-data-format * add basic tabular data format support * string updates * finalize line graph implementation with tabular data support * cleanup * finalize scatter graph with support for tabular data * commented out ideas for the data format * time-series support for tabular data within line graph * scatter support * optimize logic to find main vertical & horizontal axes * remove primary & secondary labels * bubble chart support * grouped bar support * horizontal grouped bar * fix legend filtering * fix bubble and scatter * fix bar hover errors * simple bar support * simple bar time-series support * horizontal simple bar support * more graph support * fix pie tooltip * fix donut center value * fix line & scatter demo ranges * fix bar demos * stacked data supprot * backwards data format compatibility * fix plotting of datums with a value of 0 * fixed stacked bar tooltip * remove primary, secondary, useAsGraphDomain/Range * Update packages/core/src/model.ts Co-Authored-By: natashadecoste <[email protected]> * apply suggested PR changes * fix group bar positioning issues * apply PR suggested changes * Update packages/core/demo/data/bar.ts Co-Authored-By: natashadecoste <[email protected]> * Update packages/core/demo/data/bar.ts Co-Authored-By: natashadecoste <[email protected]> * Update packages/core/demo/data/bar.ts Co-Authored-By: natashadecoste <[email protected]> * rename "identifier" to "mapsTo" * add tutorials section to core storybook * add links to errors * remove unnecessary comment * add custom color scale support * apply PR suggested changes * fix tests Co-authored-by: natashadecoste <[email protected]> * v0.30.8 * Apply suggestions from code review Co-Authored-By: Eliad Moosavi <[email protected]> * applied suggestions from review * fix ruler css * Update packages/core/src/components/axes/ruler.ts Co-Authored-By: Eliad Moosavi <[email protected]> * Update packages/core/src/styles/components/_ruler.scss Co-Authored-By: Eliad Moosavi <[email protected]> * Update packages/core/src/components/axes/ruler.ts Co-Authored-By: Eliad Moosavi <[email protected]> * add suggestions from review * Update packages/core/demo/data/line.ts Co-Authored-By: natashadecoste <[email protected]> * Apply suggestions from code review Co-Authored-By: natashadecoste <[email protected]> * enable ruler on bubble and scatter * disable mouse listeners on grid * enable ruler for every scale type * fix ruler on linear scales, refactor matches logic Co-authored-by: Zvonimir Fras <[email protected]> Co-authored-by: Natasha DeCoste <[email protected]> Co-authored-by: carbon-bot <[email protected]> Co-authored-by: Eliad Moosavi <[email protected]> * Ruler fix (carbon-design-system#598) * fix elements highlighting * fix multiple matching points * refactor * dead code * fix type * refactor reducer logic * more dead code * Update packages/core/src/components/axes/ruler.ts Co-Authored-By: Eliad Moosavi <[email protected]> * apply suggestion from review * rename * add orientation support * fix wrong y offset in mouse coords * better typing Co-authored-by: Eliad Moosavi <[email protected]> * fix vue type check for charting data * Add Svelte wrappers (carbon-design-system#569) * feat: add svelte wrappers * chore(svelte): format babelrc, rollup config * chore(deps-dev): lock @storybook/svelte version Co-Authored-By: Eliad Moosavi <[email protected]> * chore(deps-dev): lock svelte version Co-Authored-By: Eliad Moosavi <[email protected]> * chore(deps-dev): lock svelte-loader version Co-Authored-By: Eliad Moosavi <[email protected]> * docs(svelte): fill in Codesandbox section * chore(svelte): define maintainers, contributors in package.json * docs(svelte): add codesandbox * chore(svelte): update package version to 0.30.18 Co-Authored-By: Eliad Moosavi <[email protected]> * chore(yarn): rebuild lockfile to fix errored ci Co-authored-by: Eliad Moosavi <[email protected]> * Update README.md * v0.30.19 * Merge pull request carbon-design-system#581 from accurat/radar * Radar setup * Radar: create center and spokes * Radar refactor * Radar: Do not render anything if width or height are 0 * Radar: create blobs (wip) * Radar: set colors * Radar: refactor * Radar: create x axes * Radar: refactor * Radar: fix color opacity * Radar: Compute ticks with a minimum value * Radar: draw y axis * Radar: y axes start from the min tick value * Radar: add exit for x axes * Radar: blob creation refactor * Radar: rename classes * Radar: fix class name * Radar: mini refactor * Radar: fix blobs bind * Radar: style changes * Radar: fix min radius logic * Radar: bind displayData to x axes not data * Radar: add transitions * Radar: add key labels (wip) * Radar: change margin value * Radar: fix labels position * fix(core): fix backwards compatibility for pie/donut (carbon-design-system#576) * fix(core): fix pie model to ignore dataset name when converting to tabular * apply review changes * provide all datapoint info to stacked bar tooltips (carbon-design-system#573) * Merge pull request carbon-design-system#574 from theiliad/axis-formatters * optimize axis tick formatting * Update packages/core/src/components/axes/axis.ts Co-Authored-By: natashadecoste <[email protected]> * optimize axis formatter for time-scale when user has already provided one Co-authored-by: natashadecoste <[email protected]> * v0.30.12 * fix(core): Support for Horizontal Line and Scatter Chart * fix line graph update issues * v0.30.13 * Change method name * v0.30.14 * Fix linting problem about methods order * v0.30.15 * Radar: fix y axes transitions * Code comments for tools.ts (carbon-design-system#416) * update documentation for tools.ts * docs(tools.ts): api documentation Co-authored-by: Eliad Moosavi <[email protected]> * remove bbox dependency on pie labels * Merge pull request carbon-design-system#588 from accurat/invalid-time-value-bug * Fix bug `RangeError Invalid time value` * Extends domain refactor * Time series: add example with addSpaceOnEdge = 0 * Rename functions * Change method order * v0.30.16 * v0.30.17 * Radar: use the new .join d3 method * Use join to manage enter, update, exit logic * Radar: fill missing data * Radar: fix animations but need a refactor * Radar: add events * Radar: add tooltip * Radar: miss an import * Radar: use groupMapsTo * Radar: number of spokes doesn't change * Radar: use groupMapsTo for data mapping * Radar: show NA when data are missing * Radar: add y labels * Radar: remove events on blobs * Radar: left align * Radar: create rectangles over x axis * Radar: make x axis dashed on mouse over * Radar: add dots * Radar: move utility functions in another file * Radar: fix radial label placement for negative angles * Radar: refactor * Radar: radialLabelPlacement refactor * Radar: better logic to center chart * Radar: fix x axis style when overed * Radar: change blobs opacity * Radar: create y axes transition * Radar: create x axes transition * Radar: create blobs transition * Radar: x and y labels transition * Radar: fix transitions * Radar: more left space for y labels * Radar: remove unused imports * Radar: use the right transitions * Radar: remove logs * Radar: remove debug stuff * Radar: update y labels * Radar: fix Firefox bug * Radar: move constants to configuration * Radar: rename variables * Radar: fix typo * Radar: update comments * Radar: move lodash methods inside Tools * Radar: add examples and make radar more generic * Radar: fix tooltip value * Radar: fix tooltip data order * Radar: fix radar default formatter * Radar: fix showing dots * Radar: use variable instead of recompute value * Radar: create enums from textAnchor and dominantBaseline values * Radar: put dots radius to radar configuration * Radar: use tabs instead of spaces * Radar: use helper function for accesing properties * Radar: get property from options Co-authored-by: natashadecoste <[email protected]> Co-authored-by: Eliad Moosavi <[email protected]> Co-authored-by: carbon-bot <[email protected]> Co-authored-by: Serena Girardi <[email protected]> Co-authored-by: Eliad Moosavi <[email protected]> * v0.30.20 Co-authored-by: Fei <[email protected]> Co-authored-by: carbon-bot <[email protected]> Co-authored-by: Luca Falasco <[email protected]> Co-authored-by: Zvonimir Fras <[email protected]> Co-authored-by: Natasha DeCoste <[email protected]> Co-authored-by: Eliad Moosavi <[email protected]> Co-authored-by: Eliad Moosavi <[email protected]> Co-authored-by: Eric Liu <[email protected]> Co-authored-by: Serena Girardi <[email protected]>

fix(core): fix pie model to ignore dataset name when converting to ta…

9667385

…bular

natashadecoste requested review from cal-smith and theiliad April 14, 2020 19:42

natashadecoste requested a review from a team as a code owner April 14, 2020 19:42

theiliad requested changes Apr 14, 2020

View reviewed changes

cal-smith previously approved these changes Apr 14, 2020

View reviewed changes

natashadecoste added 2 commits April 16, 2020 13:28

Merge branch 'master' of https://github.com/carbon-design-system/carb…

15207e0

…on-charts into pie-model-tabular

apply review changes

cc3762e

natashadecoste dismissed cal-smith’s stale review via cc3762e April 16, 2020 17:36

theiliad approved these changes Apr 16, 2020

View reviewed changes

cal-smith approved these changes Apr 17, 2020

View reviewed changes

theiliad merged commit aed1a4d into carbon-design-system:master Apr 17, 2020

theiliad added the type: bug 🐛 Something isn't working label Apr 17, 2020

theiliad pushed a commit to theiliad/carbon-charts that referenced this pull request May 17, 2021

fix(core): fix backwards compatibility for pie/donut (carbon-design-s…

1c8a5be

…ystem#576) * fix(core): fix pie model to ignore dataset name when converting to tabular * apply review changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(core): fix backwards compatibility for pie/donut #576

fix(core): fix backwards compatibility for pie/donut #576

natashadecoste commented Apr 14, 2020

netlify bot commented Apr 14, 2020 •

edited

Loading

netlify bot commented Apr 14, 2020 •

edited

Loading

netlify bot commented Apr 14, 2020 •

edited

Loading

theiliad Apr 14, 2020

natashadecoste Apr 16, 2020

cal-smith left a comment

cal-smith left a comment

fix(core): fix backwards compatibility for pie/donut #576

fix(core): fix backwards compatibility for pie/donut #576

Conversation

natashadecoste commented Apr 14, 2020

Updates

Demo screenshot or recording

data

before

after

Review checklist (for reviewers only)

netlify bot commented Apr 14, 2020 • edited Loading

netlify bot commented Apr 14, 2020 • edited Loading

netlify bot commented Apr 14, 2020 • edited Loading

theiliad Apr 14, 2020

Choose a reason for hiding this comment

natashadecoste Apr 16, 2020

Choose a reason for hiding this comment

cal-smith left a comment

Choose a reason for hiding this comment

cal-smith left a comment

Choose a reason for hiding this comment

netlify bot commented Apr 14, 2020 •

edited

Loading

netlify bot commented Apr 14, 2020 •

edited

Loading

netlify bot commented Apr 14, 2020 •

edited

Loading