Skip to content

Commit 16c5d30

Browse files
committed
github: update Pull Request template
+ Move from Markdown checklist to text. The first PR comment is presented as text when creating it. + Add the note about Signed-Off-By: not being required. Change-Id: I0650891dcf11ed7dd367007148730ba2917784fe Reviewed-on: https://go-review.googlesource.com/95696 Reviewed-by: Brad Fitzpatrick <[email protected]>
1 parent 2629703 commit 16c5d30

File tree

2 files changed

+25
-21
lines changed

2 files changed

+25
-21
lines changed

.github/PULL_REQUEST_TEMPLATE

+25
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
This PR will be imported into Gerrit with the title and first
2+
comment (this text) used to generate the subject and body of
3+
the Gerrit change.
4+
5+
**Please ensure you adhere to every item in this list.**
6+
7+
More info can be found at https://github.com/golang/go/wiki/CommitMessage
8+
9+
+ The PR title is formatted as follows: `net/http: frob the quux before blarfing`
10+
+ The package name goes before the colon
11+
+ The part after the colon uses the verb tense + phrase that completes the blank in,
12+
"This change modifies Go to ___________"
13+
+ Lowercase verb after the colon
14+
+ No trailing period
15+
+ Keep the title as short as possible. ideally under 76 characters or shorter
16+
+ No Markdown
17+
+ The first PR comment (this one) is wrapped at 76 characters, unless it's
18+
really needed (ASCII art, table, or long link)
19+
+ If there is a corresponding issue, add either `Fixes #1234` or `Updates #1234`
20+
(the latter if this is not a complete fix) to this comment
21+
+ If referring to a repo other than `golang/go` you can use the
22+
`owner/repo#issue_number` syntax: `Fixes golang/tools#1234`
23+
+ We do not use Signed-off-by lines in Go. Please don't add them.
24+
Our Gerrit server & GitHub bots enforce CLA compliance instead.
25+
+ Delete these instructions once you have read and applied them

.github/PULL_REQUEST_TEMPLATE.md

-21
This file was deleted.

0 commit comments

Comments
 (0)