Skip to content

Commit 083518f

Browse files
committed
fix(response): ensure null or client/server response is returned
1 parent b365934 commit 083518f

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

src/kerberos_client.cc

+5-4
Original file line numberDiff line numberDiff line change
@@ -93,11 +93,12 @@ class ClientStepWorker : public Nan::AsyncWorker {
9393
private:
9494
virtual void HandleOKCallback() {
9595
Nan::HandleScope scope;
96-
v8::Local<v8::Value> argv[] = {
97-
Nan::Null(),
98-
Nan::New(_client->_state->response).ToLocalChecked()
99-
};
96+
v8::Local<v8::Value> response = Nan::Null();
97+
if (_client->_state->response != NULL) {
98+
response = Nan::New(_client->_state->response).ToLocalChecked();
99+
}
100100

101+
v8::Local<v8::Value> argv[] = { Nan::Null(), response };
101102
callback->Call(2, argv, async_resource);
102103
}
103104

src/kerberos_server.cc

+5-4
Original file line numberDiff line numberDiff line change
@@ -93,11 +93,12 @@ class ServerStepWorker : public Nan::AsyncWorker {
9393
private:
9494
virtual void HandleOKCallback() {
9595
Nan::HandleScope scope;
96-
v8::Local<v8::Value> argv[] = {
97-
Nan::Null(),
98-
Nan::New(_server->_state->response).ToLocalChecked()
99-
};
96+
v8::Local<v8::Value> response = Nan::Null();
97+
if (_server->_state->response != NULL) {
98+
response = Nan::New(_server->_state->response).ToLocalChecked();
99+
}
100100

101+
v8::Local<v8::Value> argv[] = { Nan::Null(), response };
101102
callback->Call(2, argv, async_resource);
102103
}
103104

0 commit comments

Comments
 (0)