Skip to content

Commit b772dde

Browse files
committed
fix(check-password): correctly validate parameters, fix test
1 parent 0cb8b90 commit b772dde

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

lib/kerberos.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,10 @@ function validateParameter(parameter, spec) {
6161
*/
6262
function checkPassword(username, password, service, defaultRealm, callback) {
6363
if (typeof defaultRealm === 'function') (callback = defaultRealm), (defaultRealm = null);
64-
validateParameter(username, { name: 'service', type: 'string' });
65-
validateParameter(password, { name: 'options', type: 'string' });
66-
validateParameter(service, { name: 'options', type: 'string' });
67-
validateParameter(defaultRealm, { name: 'options', type: 'string' });
64+
validateParameter(username, { name: 'username', type: 'string' });
65+
validateParameter(password, { name: 'password', type: 'string' });
66+
validateParameter(service, { name: 'service', type: 'string' });
67+
validateParameter(defaultRealm, { name: 'defaultRealm', type: 'string' });
6868
validateParameter(callback, { name: 'callback', type: 'function' });
6969

7070
kerberos.checkPassword(username, password, service, defaultRealm, callback);
@@ -82,7 +82,7 @@ function checkPassword(username, password, service, defaultRealm, callback) {
8282
*/
8383
function principalDetails(service, hostname, callback) {
8484
validateParameter(service, { name: 'service', type: 'string' });
85-
validateParameter(hostname, { name: 'options', type: 'string' });
85+
validateParameter(hostname, { name: 'hostname', type: 'string' });
8686
validateParameter(callback, { name: 'callback', type: 'function' });
8787

8888
kerberos.principalDetails(service, hostname, callback);

test/kerberos_tests.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ describe('Kerberos', function() {
2929
kerberos.checkPassword(username, password, service, realm.toUpperCase(), err => {
3030
expect(err).to.not.exist;
3131

32-
kerberos.checkPassword(username, 'incorrect-password', service, realm.toUpperCase, err => {
32+
kerberos.checkPassword(username, 'incorrect-password', service, realm.toUpperCase(), err => {
3333
expect(err).to.exist;
3434
done();
3535
});

0 commit comments

Comments
 (0)