Skip to content
This repository was archived by the owner on Jan 6, 2022. It is now read-only.

[Feature Request ] Song Lyrics #44

Closed
Evi-2003 opened this issue May 17, 2021 · 10 comments · Fixed by #238
Closed

[Feature Request ] Song Lyrics #44

Evi-2003 opened this issue May 17, 2021 · 10 comments · Fixed by #238
Assignees
@vapormusic
Labels
enhancement New feature or request

Comments

@Evi-2003
Copy link

Is it possible to add a song lyrics options in Apple Music Electron?
Example:
image
@cryptofyre
Copy link
Member

I could definitely look into it. I don't know about live lyrics but I could definitely add a button that opens a genius lyrics window or something.

@cryptofyre cryptofyre added the enhancement New feature or request label May 18, 2021
@devilAPI
Copy link
Contributor

devilAPI commented May 27, 2021 •
edited
Loading

im sure that apple is gonna implement it at some point

@Nosh118
Copy link

Nosh118 commented Jun 22, 2021 •
edited
Loading

I wonder if it would be possible to pull time-synced lyrics from Musixmatch or even .lrc files from Deezer and use Genius as a fallback for non-synced lyrics?

@ghost
Copy link

ghost commented Jul 6, 2021

It is possible to query time-synced lyrics from MusicKit: MusicKit.getInstance().api.lyric(songId)

@quacksire quacksire added the Waiting For 🍎 Waiting for Apple to fix or add a feature label Jul 8, 2021
@coredev-uk coredev-uk mentioned this issue Jul 24, 2021
Closed
@quacksire
Copy link
Member

👀
https://genius.com/developers

@coredev-uk coredev-uk added the awaiting third party Waiting on an issue to be fixed or implemented by a third party. label Oct 3, 2021
@vapormusic
Copy link
Contributor

I'm trying to add this, however i have no prior Electron experience. Would love to have some help!
Capture

@quacksire
Copy link
Member

This looks surprisingly good for a start. Good Job!

I have one question:
Does the lyric get selected or did you do that?

@vapormusic
Copy link
Contributor

vapormusic commented Oct 7, 2021 •
edited
Loading

@child-duckling it's an lrc file, so that's the current line. (and yes, you can select the line to seek the song).

@vapormusic
Copy link
Contributor

vapormusic commented Oct 8, 2021 •
edited
Loading

I put up a PR: #238 .

@cryptofyre cryptofyre linked a pull request Oct 8, 2021 that will close this issue
Synced Lyrics #238
Merged
@quacksire quacksire removed Waiting For 🍎 Waiting for Apple to fix or add a feature awaiting third party Waiting on an issue to be fixed or implemented by a third party. labels Oct 8, 2021
@vapormusic vapormusic reopened this Oct 14, 2021
@vapormusic
Copy link
Contributor

Done in 3.0.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vapormusic vapormusic

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Synced Lyrics vapormusic/Apple-Music-Electron
7 participants
@quacksire @vapormusic @cryptofyre @devilAPI @coredev-uk @Nosh118 @Evi-2003