Skip to content
This repository was archived by the owner on Jan 6, 2022. It is now read-only.

Last.FM Scrobbling #55

Closed
decafhotchocolate opened this issue May 19, 2021 · 12 comments
Closed

Last.FM Scrobbling #55

decafhotchocolate opened this issue May 19, 2021 · 12 comments
Assignees
Labels
enhancement New feature or request

Comments

@decafhotchocolate
Copy link

It'd be quite neat to have I think :) I'm assuming it won't be too hard to handle considering the information in Discord Rich Presence is close enough to what is needed for scrobbling (knowing when a track is playing, what that track is, etc.)

@cryptofyre
Copy link
Member

Does the desktop app scrobbler not do it?
https://www.last.fm/about/trackmymusic

@decafhotchocolate
Copy link
Author

I've read that it does, at least one the regular client, but I probably should've mentioned I'm on linux. I recognize from another request though that that's not your top priority right now, so shrug.

@cryptofyre
Copy link
Member

I could likely make a scrobbler module with a config option. Signing in would be a interesting task however.

@kikandychan
Copy link

the official last.fm scrobbler on windows is not working with Apple Music Electron.
so please try to add native apple music scrobber support.
as i know the chrome extension web-scrobbler is working with Apple Music Web.

@cryptofyre
Copy link
Member

Ill see what I can do.

@cryptofyre cryptofyre added the enhancement New feature or request label May 30, 2021
@cryptofyre cryptofyre self-assigned this May 30, 2021
@cryptofyre
Copy link
Member

Took a while but this feature is now available! https://github.com/cryptofyre/Apple-Music-Electron/releases/tag/v2.4.0 ab61d4a

@ghost
Copy link

ghost commented Jul 6, 2021

The scrobbler does not appear to work for me - wondering if this has to do with the fact that clicking the link on the setup page shows this after clicking allow access (even though it shows a token in the URL). Not sure if this is common or just a me problem.

lfm

@cryptofyre
Copy link
Member

The API key being invalid is just the standard no callback error from LastFM's API. I didn't want to setup a callback website so copying the key from the URL is fine.

@ghost
Copy link

ghost commented Jul 6, 2021

Right true it does seem to use the API key and generate session.json successfully, however I'm not seeing it actually scrobble anything, with dev tools enabled I don't see any requests made to LFM and looking in the log file it appears to log in successfully but not log anything indicating a scrobble attempt at all - neither an error nor success message.

@cryptofyre
Copy link
Member

I just looked into that and fixed it. Beta 2 should be out shortly.

@cryptofyre
Copy link
Member

Beta 2 is out and should fix your scrobbling problems.

@ghost
Copy link

ghost commented Jul 8, 2021

It does function now. Just a few suggestions for improvement -

  1. From a fresh install, it initially shows a bunch of error popups the first time LFM logs in.
  2. Send the album field as well, right now it just sends the artist and song, which can lead to things being counted under the wrong album if the song is found in multiple albums.
  3. Don't scrobble songs immediately, right now they scrobble as soon as they're what's playing. If a song comes on that I decide to skip, it'll scrobble it anyway. Most other software with LFM integration scrobble only if half of the song was listened to.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants