Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Cannot find module ckeditor4-integrations-common" error after upgrading to 2.2.0 #191

Closed
nzacca opened this issue May 10, 2021 · 2 comments
Assignees
Labels
status:confirmed An issue confirmed by the development team. type:bug A bug.

Comments

@nzacca
Copy link

nzacca commented May 10, 2021

Are you reporting a feature request or a bug?

Bug

Provide detailed reproduction steps (if any)

  1. Install ckeditor4-angular 2.2.0
  2. Examine the dependencies of ckeditor in the lock file

Expected result

ckeditor4-integrations-common should be installed as dependency.

Actual result

ckeditor4-integrations-common is not installed. Components are throwing errors that it cannot find ckeditor4-integrations-common for example:

Cannot find module 'ckeditor4-integrations-common' from '../../node_modules/ckeditor4-angular/bundles/ckeditor4-angular.umd.js'

Other details

  • CKEditor version: 2.2.0

package.json in the tar file does not appear to have ckeditor4-integrations-common listed in the dependencies: https://registry.npmjs.org/ckeditor4-angular/-/ckeditor4-angular-2.2.0.tgz

package.json in root does: https://github.com/ckeditor/ckeditor4-angular/blob/v2.2.0/package.json#L30

package.json in the distribution does not: https://github.com/ckeditor/ckeditor4-angular/blob/v2.2.0/dist/package.json#L34

@MMMalik
Copy link
Contributor

MMMalik commented May 12, 2021

Confirmed. Package ckeditor4-integrations-common is missing inside nested package.json dependencies field.

@MMMalik MMMalik self-assigned this May 12, 2021
@MMMalik MMMalik added status:confirmed An issue confirmed by the development team. size:XXS type:bug A bug. labels May 12, 2021
@Dumluregn
Copy link
Collaborator

Closed in #193.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

3 participants