Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the minimal version of Angular to 13+ to ensure compatibility with Angular 16+ #242

Closed
EduardoCastanho opened this issue May 4, 2023 · 4 comments · Fixed by #243
Labels
status:confirmed An issue confirmed by the development team. type:feature A feature request.

Comments

@EduardoCastanho
Copy link

EduardoCastanho commented May 4, 2023

Provide detailed reproduction steps (if any)

  1. Run project compilation.

Expected result

Compilation will proceed correctly

Actual result

There is an error during compilation:

Error: src/app/app.module.ts:207:5 - error NG6002: 'CKEditorModule' does not appear to be an NgModule class.

207 CKEditorModule,
~~~~~~~~~~~~~~

node_modules/ckeditor4-angular/ckeditor.module.d.ts:5:22
5 export declare class CKEditorModule {
~~~~~~~~~~~~~~
This likely means that the library (ckeditor4-angular) which declares CKEditorModule is not compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy.

Other details

Since the previous versions of Angular which used View Engine to compile the project were replaced by new Ivy architecture, there is no way to run compilation in newer versions of Angular(13+) and we need add support for it.

@KarolDawidziuk
Copy link
Contributor

Hi @EduardoCastanho

We would like to help solve your issue but it seems you have missed our template for feature requests and bug reports. Their purpose is to make sure you provide the most sufficient and clear description. In this case, it is very difficult to see where the problem lies and a working example would be very helpful. Without this, we are unable to have a closer look at your problem.

Please refer to our guide on how to report issues on the tracker, and open a new issue using the template as this one is being closed now.

@KarolDawidziuk KarolDawidziuk added the resolution:invalid Not a valid issue (wrong request type, support requests, etc). label May 11, 2023
@KernelFolla
Copy link

I'm stuck too so please reopen this, you would still have other identical reports:)

There's not much to explain to reproduce, it just doesn't work in angular 16 because it's not compiled with Ivy and ngcc support is removed so actually ckeditor4-angular doesn't support angular 16

@EduardoCastanho
Copy link
Author

Hi @EduardoCastanho

We would like to help solve your issue but it seems you have missed our template for feature requests and bug reports. Their purpose is to make sure you provide the most sufficient and clear description. In this case, it is very difficult to see where the problem lies and a working example would be very helpful. Without this, we are unable to have a closer look at your problem.

Please refer to our guide on how to report issues on the tracker, and open a new issue using the template as this one is being closed now.

I don't miss the template! using a template for a simple and obvious thing .... only noise .

With this reply and closing the issue, without even tackle the issue It seems that there is no will to solve this problem, at least in a near future ...

https://github.com/ckeditor/ckeditor5-angular

May be ?

@KarolDawidziuk
Copy link
Contributor

@EduardoCastanho, Using the template is useful to check the reported issue from our side because it contains useful information for us to confirm it on not. In addition, the information may be useful to other community members.

I am re-opening this issue.

@KarolDawidziuk KarolDawidziuk reopened this Jun 5, 2023
@KarolDawidziuk KarolDawidziuk changed the title Angular 16 and Ivy ... Ivy compiler for Angular v13 and later Jun 5, 2023
@KarolDawidziuk KarolDawidziuk added type:feature A feature request. status:confirmed An issue confirmed by the development team. type:bug A bug. and removed resolution:invalid Not a valid issue (wrong request type, support requests, etc). type:feature A feature request. type:bug A bug. labels Jun 12, 2023
@KarolDawidziuk KarolDawidziuk changed the title Ivy compiler for Angular v13 and later Update the minimal version of Angular to 13+ to ensure compatibility with Angular 16+ Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants