Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown accessibility label is not updated when combo value changes #4493

Closed
f1ames opened this issue Jan 19, 2021 · 1 comment
Closed

Dropdown accessibility label is not updated when combo value changes #4493

f1ames opened this issue Jan 19, 2021 · 1 comment
Assignees
Labels
accessibility Issue related to accessibility. plugin:font The plugin which probably causes the issue. plugin:format The plugin which probably causes the issue. plugin:richcombo The plugin which probably causes the issue. plugin:stylescombo The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. support:2 An issue reported by a commercially licensed client. type:bug A bug.
Milestone

Comments

@f1ames
Copy link
Contributor

f1ames commented Jan 19, 2021

Type of report

Bug

Provide detailed reproduction steps (if any)

Our richcombo plugin (and all other plugins which use it underneath) does not comply with the accessibility recommendation described in https://www.w3.org/WAI/WCAG21/Understanding/label-in-name.html - Ensure that elements labelled through their content must have their visible text as part of their accessible name.

This is caused by the fact that richcombo accessibility label is not updated when combo value changes so it always holds the initial lable.

  1. Go to https://codepen.io/f1ames/pen/rNMdgYL?editors=1010 or any editor instance with Font plugin.
  2. Open browser dev console and find combo label element <span id="cke_15_label" class="cke_combo_label">Font</span> (ids may vary).
  3. Change Font dropdown value.

Expected result

Combo label element text changes and contains name of the value selected.

Actual result

Combo label element text does not change and doesn't reflect selected value.

Other details

  • Browser: All (Tested on Chrome)
  • OS: All (Tested on Linux)
  • CKEditor version: 4.10.0+ (but it seems it always worked like that)
  • Installed CKEditor plugins: richcombo
@f1ames f1ames added type:bug A bug. status:confirmed An issue confirmed by the development team. plugin:font The plugin which probably causes the issue. plugin:format The plugin which probably causes the issue. plugin:stylescombo The plugin which probably causes the issue. accessibility Issue related to accessibility. plugin:richcombo The plugin which probably causes the issue. support:2 An issue reported by a commercially licensed client. size:M labels Jan 19, 2021
@f1ames f1ames added this to the 4.16.1 milestone Feb 23, 2021
@Comandeer Comandeer self-assigned this Mar 22, 2021
@CKEditorBot
Copy link
Collaborator

Closed in #4580

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issue related to accessibility. plugin:font The plugin which probably causes the issue. plugin:format The plugin which probably causes the issue. plugin:richcombo The plugin which probably causes the issue. plugin:stylescombo The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. support:2 An issue reported by a commercially licensed client. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

3 participants