Skip to content
This repository was archived by the owner on Jun 26, 2020. It is now read-only.

Commit aa24686

Browse files
authoredAug 12, 2019
Merge pull request #40 from ckeditor/t/ckeditor5/1403
Fix: The UI buttons should be marked as toggleable for better assistive technologies support (see ckeditor/ckeditor5#1403).
2 parents c48b703 + fa34b49 commit aa24686

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed
 

‎src/blockquoteui.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@ export default class BlockQuoteUI extends Plugin {
3535
buttonView.set( {
3636
label: t( 'Block quote' ),
3737
icon: quoteIcon,
38-
tooltip: true
38+
tooltip: true,
39+
isToggleable: true
3940
} );
4041

4142
// Bind button model to command.

‎tests/blockquoteui.js

+1
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ describe( 'BlockQuoteUI', () => {
4040
expect( button ).to.have.property( 'label', 'Block quote' );
4141
expect( button ).to.have.property( 'icon' );
4242
expect( button ).to.have.property( 'tooltip', true );
43+
expect( button ).to.have.property( 'isToggleable', true );
4344
} );
4445

4546
it( 'has isOn bound to command\'s value', () => {

0 commit comments

Comments
 (0)
This repository has been archived.